-
Notifications
You must be signed in to change notification settings - Fork 0
knip: landing-page keeps a redundant ignore and passes config hints #641
Copy link
Copy link
Closed
Labels
agent-backlogLow-risk, bounded work a background agent can autonomously claim and fixLow-risk, bounded work a background agent can autonomously claim and fixagent:weakDoable with no repository secrets, no MCP write access, and no app renderDoable with no repository secrets, no MCP write access, and no app renderarea:knipScoped to knip/deadcode configurationScoped to knip/deadcode configurationeffort:sSmall, single-workspace changeSmall, single-workspace changerisk:lowBounded blast radius; safe for autonomous executionBounded blast radius; safe for autonomous executionstatus:workingClaimed by a background agent; GitHub labels are the only claim stateClaimed by a background agent; GitHub labels are the only claim state
Description
Activity
Metadata
Metadata
Assignees
Labels
agent-backlogLow-risk, bounded work a background agent can autonomously claim and fixLow-risk, bounded work a background agent can autonomously claim and fixagent:weakDoable with no repository secrets, no MCP write access, and no app renderDoable with no repository secrets, no MCP write access, and no app renderarea:knipScoped to knip/deadcode configurationScoped to knip/deadcode configurationeffort:sSmall, single-workspace changeSmall, single-workspace changerisk:lowBounded blast radius; safe for autonomous executionBounded blast radius; safe for autonomous executionstatus:workingClaimed by a background agent; GitHub labels are the only claim stateClaimed by a background agent; GitHub labels are the only claim state
Problem
On main, CI run https://github.com/zapPilot/zapEngine/actions/runs/35965731315 (job code-quality, head b96ad1c, 2026-09-24T06:42Z) shows
@zapengine/landing-page#deadcodeprintingConfiguration hints (1): src/components/docs/AssetLabel.tsx knip.ts Remove from ignore; a local run on main 4473612 prints the same single hint. The hint never fails CI because apps/landing-page/package.json runsknip --files --exports --dependencieswithout--treat-config-hints-as-errors, unlike the app, alpha-etl, podcast-pipeline and brand-assets workspaces. The ignore entry in apps/landing-page/knip.ts is redundant: knip's vitest entry (src/**/__tests__/**/*.{test,spec}.{ts,tsx}) already reaches AssetLabel.tsx through src/components/docs/tests/AssetLabel.test.tsx. Environment: CI and local only; seen on the latest main CI run 2026-09-24.Expected outcome
landing-page's knip config carries no redundant ignore, and its deadcode script fails on configuration hints so future stale knip config is caught in CI.
Acceptance criteria
knip --files --exports --dependencies --treat-config-hints-as-errors.pnpm --filter @zapengine/landing-page deadcodeexits 0 and prints noConfiguration hintssection.pnpm --filter @zapengine/landing-page teststill passes, including src/components/docs/tests/AssetLabel.test.tsx.Relevant files / area
Out of scope