Skip to content

knip: landing-page keeps a redundant ignore and passes config hints #641

Description

@i-xtsu-sixyou-ken-mei

Problem

On main, CI run https://github.com/zapPilot/zapEngine/actions/runs/35965731315 (job code-quality, head b96ad1c, 2026-09-24T06:42Z) shows @zapengine/landing-page#deadcode printing Configuration hints (1): src/components/docs/AssetLabel.tsx knip.ts Remove from ignore; a local run on main 4473612 prints the same single hint. The hint never fails CI because apps/landing-page/package.json runs knip --files --exports --dependencies without --treat-config-hints-as-errors, unlike the app, alpha-etl, podcast-pipeline and brand-assets workspaces. The ignore entry in apps/landing-page/knip.ts is redundant: knip's vitest entry (src/**/__tests__/**/*.{test,spec}.{ts,tsx}) already reaches AssetLabel.tsx through src/components/docs/tests/AssetLabel.test.tsx. Environment: CI and local only; seen on the latest main CI run 2026-09-24.

Expected outcome

landing-page's knip config carries no redundant ignore, and its deadcode script fails on configuration hints so future stale knip config is caught in CI.

Acceptance criteria

  • apps/landing-page/knip.ts no longer lists src/components/docs/AssetLabel.tsx under ignore (drop the ignore key if it becomes empty).
  • apps/landing-page/package.json deadcode script is knip --files --exports --dependencies --treat-config-hints-as-errors.
  • pnpm --filter @zapengine/landing-page deadcode exits 0 and prints no Configuration hints section.
  • pnpm --filter @zapengine/landing-page test still passes, including src/components/docs/tests/AssetLabel.test.tsx.

Relevant files / area

  • apps/landing-page/knip.ts
  • apps/landing-page/package.json

Out of scope

  • Deleting or editing AssetLabel.tsx or its test (it has no production importer today; keeping it is a separate product decision).
  • Other workspaces' knip configs or deadcode scripts, and packages/knip-config.
  • Lint, coverage or jscpd thresholds, workflows, env, migrations.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-backlogLow-risk, bounded work a background agent can autonomously claim and fixagent:weakDoable with no repository secrets, no MCP write access, and no app renderarea:knipScoped to knip/deadcode configurationeffort:sSmall, single-workspace changerisk:lowBounded blast radius; safe for autonomous executionstatus:workingClaimed by a background agent; GitHub labels are the only claim state

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions