fix(broker): recover asyncpg listener after disconnect - #25
Open
GefMar wants to merge 1 commit into
Open
Conversation
Recreate terminated listener connections with bounded backoff and reconcile durable messages missed during the LISTEN gap. Preserve atomic claims and shutdown-safe lifecycle handling. Add regression coverage for listener termination, reconnect races, missed notifications, and reconciliation pagination. Refs taskiq-python/taskiq#633
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recreate terminated asyncpg listener connections with bounded backoff and reconcile durable messages missed during the
LISTENgap. Preserve atomic claims and shutdown-safe lifecycle handling.Add regression coverage for listener termination, reconnect races, missed notifications, and reconciliation pagination.
Refs taskiq-python/taskiq#633.
Type of Change
Changes Made
LISTENregistration using bounded keyset pagination and atomicDELETE ... RETURNINGclaims.Testing
Coverage includes:
pg_terminate_backend();The baseline commit left the publish-before-worker row queued and undelivered. The fixed working tree delivered the same scenario and removed the claimed row.
Test Configuration
Performance Impact
Performance details:
Normal notification processing retains the existing atomic claim path. Additional database work is limited to a bounded, paginated reconciliation scan during listener startup and after reconnect. Reconnect attempts use capped backoff with jitter to avoid tight retry loops.
Documentation
Checklist
Related Issues
Refs taskiq-python/taskiq#633.
Screenshots (if applicable)
Not applicable.
Additional Notes
NOTIFYpath but are not automatically reconciled because their original channel cannot be determined safely.