Repository navigation
fix(v2): avoid empty catalog during discovery refresh (refs #159) - #160
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #159 where model discovery refresh or cache expiration caused first requests to transiently return 404 (Model not found).
Root Cause
refreshFromCurrentConfig()previously invokedawait ctx.provider.reload()unconditionally at the beginning of every refresh. In OpenCode V2,provider.reload()immediately causes the host to recalculate provider/model transforms. During normal discovery and cache expiration refreshes, invoking this before the upstream/v1/modelsHTTP request completes placed the model registry in a transient empty/transition state while the network request was in-flight, leading to a temporary 404 window.Changes
reloadProviderConfig(defaults tofalse) inrefreshFromCurrentConfig():ctx.provider.reload(). Existing models remain fully available while background network discovery runs, andreplaceInventory()atomically materializes newly discovered models once ready.config.updated,credential.*): explicitly passesreloadProviderConfig = trueto ensure the host provider registry is synchronized before discovering models.test/v2/plugin.test.tsverifying that provider catalog reloads are deferred until model discovery completes.Related to #159 (closes #159).