fix(recorder): harden gaze correction lifecycle and fallback - #1
Merged
Yansoul merged 2 commits intoAug 10, 2026
Merged
Conversation
Author
|
Final review disposition:
Merge decision: safe to merge this source hardening PR. This does not publish a signed sidecar artifact. |
Yansoul
merged commit Aug 10, 2026
a884116
into
flowprompter-recorder-release
12 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GAZE_UNAVAILABLEonce per take when the native model cannot initializeprepare.gazeCorrection,gazeLandmarks, and the warning eventWhy
The desktop preview and the native recording path could diverge when model initialization or the second eye inference failed. The protocol schema also rejected the very gaze commands accepted by Rust. This PR makes the recording path fail closed, observable, and schema-valid.
Validation
cargo fmt --checkcargo check -p flowprompter-recorder --all-targets --locked --offlinecargo test -p flowprompter-recorder --locked --offline(54 lib + 1 main + 3 protocol/schema)cargo test -p cap-gaze --locked --offline(4/4)-D warningsok: true)Companion desktop PR
Release boundary
This merges source only. It does not build, publish, or promote a signed recorder sidecar.