Cleanup: stray autosave artifact, dead code, placeholder header - #5
Cleanup: stray autosave artifact, dead code, placeholder header#5yottanami wants to merge 1 commit into
Conversation
|
Reviewed, and re-derived each factual claim independently rather than taking the PR's word for it:
All three edited files balance. Bundling these three as one PR matches ideas#22's own explicit scoping ("bundled as one task since each item is trivial and independent"), so no unrelated-changes concern despite them being unrelated to each other. Same caveat as the rest of the batch: no agent can run |
- Deleted plugins/devel/#core.el# -- a stale Emacs autosave snapshot
from before core.el gained its Ruby LSP block, with a syntax typo
("(setq js-indent-level 2)s"). Despite #*# already being in
.gitignore, it was committed anyway (89a4842, 2026-06-26) -- that
rule predates the commit by nine months, so this wasn't a case of
the rule missing it; an exact-path `git add` on an ignored file
still adds it, only wildcard/directory adds respect .gitignore.
No other tracked files match the #*#/*~/.#.* patterns.
- plugins/wm/core.el's header had unfilled template boilerplate
("Your Name <your.email@example.com>", a placeholder URL). Filled
in with the identity every commit since 2025-09-18 actually uses
(yottanami <yottanami@gnu.org>) and the project's real URL, per
README.org and nix/package.nix's meta.homepage.
- Removed ~50 lines of dead, fully-commented-out code in
noteditor-user.el referencing use-flags/when-wm/noteditor/flags,
none of which exist anywhere in the current codebase (grepped the
whole tree). Left the one commented block that doesn't reference
those macros (loading an optional ~/.noteditor-user.el) -- reads as
an intentional usage example, not dead code from a removed feature.
30a7cba to
129571a
Compare
|
@yottanami This one's waiting on you too — no agent can run
|
Summary
Three independent, trivial cleanups bundled as one PR (each an unrelated one-off, per the issue):
plugins/devel/#core.el#deleted — a stale Emacs autosave snapshot, predating the currentcore.el's Ruby LSP block, with a syntax typo ((setq js-indent-level 2)s, a stray trailings). On why it slipped past.gitignore's#*#rule despite that rule already existing: I checked — the rule (815c818, 2025-09-18) predates the file's own commit (89a4842, 2026-06-26) by about nine months, so it's not a case of the rule missing it in time. An exact-pathgit addon an already-named file still adds it even if it matches a gitignore pattern; only wildcard/directory adds silently respect.gitignore. Checked the rest of the tree (git ls-files | grep -E '(^|/)(#.*#|.*~|\.#.*)$') — no other stray autosave/backup files are tracked.plugins/wm/core.el's header had unfilled template boilerplate (Your Name <your.email@example.com>, a placeholder URL) — filled in withyottanami <yottanami@gnu.org>(the identity every commit to this repo since 2025-09-18 actually uses — checkedgit log --format='%an <%ae>') andhttps://github.com/yottanami/noteditor(matchesREADME.organdnix/package.nix'smeta.homepage).noteditor-user.el: removed ~50 lines of dead, fully-commented-out code referencinguse-flags/when-wm/noteditor/flags— grepped the whole tree, none of those exist anywhere in the current codebase. Left the one remaining commented block (loading an optional~/.noteditor-user.el) alone since it doesn't reference those removed macros and reads as an intentional usage example rather than dead code from a removed feature.Closes Men-in-Black-5/ideas#22
Test plan
core.elto confirm it's genuinely stale, not something worth preservinguse-flags/when-wm/noteditor/flagsacross the whole tree — confirmed dead before removing#*#/*~/.#*tracked files — none found.elfiles — balancednix flake check/ a live build — nonix/emacsbinary in my environment, needs a real check