Skip to content

Fix #826: Fix copy-paste gaps in rule contract tests - #827

Merged
vjik merged 1 commit into
masterfrom
fix-826-rule-contract-tests
Sep 28, 2026
Merged

vjik merged 1 commit into
masterfrom
fix-826-rule-contract-tests

Conversation

@roxblnfk

Copy link
Copy Markdown
Member
Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #826
  • DateTimeTest and TimeTest now check getName(), skipOnError and when on DateTime/Time instead of Date.
  • NumberTest gets the same three contract checks for Integer, which had none.
  • Test-only change; no CHANGELOG entry.

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (cde9506) to head (1df44c2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #827      +/-   ##
============================================
+ Coverage     96.35%   97.14%   +0.79%     
  Complexity     1152     1152              
============================================
  Files           124      124              
  Lines          3540     3540              
============================================
+ Hits           3411     3439      +28     
+ Misses          129      101      -28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Assisted-By: Claude Sonnet 5 <noreply@anthropic.com>
@roxblnfk
roxblnfk force-pushed the fix-826-rule-contract-tests branch from 405c006 to 1df44c2 Compare September 26, 2026 22:41
@roxblnfk
roxblnfk requested review from a team and a lite review from Copilot September 27, 2026 14:03
@roxblnfk roxblnfk added the type:test Test label Sep 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

All reviewed changes are test-only, with no unresolved issues.

Review effort: Lite
Findings: None

What changed in this PR

Updates rule contract tests to cover the correct DateTime, Time, and Integer instances.

Changes:

  • Corrects DateTimeTest and TimeTest rule instances.
  • Adds Integer checks for name, skipOnError, and when.
File Description
tests/​Rule/​NumberTest.php Adds Integer contract tests.
tests/​Rule/​Date/​TimeTest.php Tests Time instead of Date.
tests/​Rule/​Date/​DateTimeTest.php Tests DateTime instead of Date.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@vjik
vjik merged commit 12ae801 into master Sep 28, 2026
32 checks passed
@vjik
vjik deleted the fix-826-rule-contract-tests branch September 28, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants