Fix #826: Fix copy-paste gaps in rule contract tests - #827
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
============================================
+ Coverage 96.35% 97.14% +0.79%
Complexity 1152 1152
============================================
Files 124 124
Lines 3540 3540
============================================
+ Hits 3411 3439 +28
+ Misses 129 101 -28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Assisted-By: Claude Sonnet 5 <noreply@anthropic.com>
roxblnfk
force-pushed
the
fix-826-rule-contract-tests
branch
from
September 26, 2026 22:41
405c006 to
1df44c2
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are test-only, with no unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Updates rule contract tests to cover the correct DateTime, Time, and Integer instances.
Changes:
- Corrects
DateTimeTestandTimeTestrule instances. - Adds
Integerchecks forname,skipOnError, andwhen.
| File | Description |
|---|---|
tests/Rule/NumberTest.php |
Adds Integer contract tests. |
tests/Rule/Date/TimeTest.php |
Tests Time instead of Date. |
tests/Rule/Date/DateTimeTest.php |
Tests DateTime instead of Date. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vjik
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateTimeTestandTimeTestnow checkgetName(),skipOnErrorandwhenonDateTime/Timeinstead ofDate.NumberTestgets the same three contract checks forInteger, which had none.