feat: numeric embedded fields - #1275
Conversation
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe visual editor now recognizes decimal, float, and integer entity fields as compatible with embedded string inputs. Numeric root fields and nested linked-entity fields can be selected and inserted as embedded expressions. Embedded numeric values are converted to plain strings during resolution. Development schemas, display-name mappings, linked-entity schemas, and local stream data now include numeric location, linked-location, and linked-product fields. Sequence Diagram(s)sequenceDiagram
participant Editor as EmbeddedFieldStringInput
participant Filter as getEmbeddedStringFilter
participant Selector as getFieldsForSelector
participant Resolver as resolveEmbeddedFieldsInString
Editor->>Filter: Expand string-compatible types
Filter->>Selector: Request numeric entity-field options
Selector-->>Editor: Return root and linked numeric fields
Editor->>Resolver: Resolve embedded numeric expression
Resolver-->>Editor: Return numeric value as text
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@starter/src/dev.config.ts`:
- Around line 12902-13052: Add the USD option to the options array for
c_linkedProduct.price.currencyCode, matching the existing schema.fields and
c_deliveryFee.currencyCode definition: textValue "USD" with displayName
"USD-United States Dollar". Leave the CTA field typeRegistryId values unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9b8d57e2-929f-41b6-838c-235f8447a6c8
📒 Files selected for processing (8)
packages/visual-editor/src/editor/EmbeddedFieldStringInput.test.tsxpackages/visual-editor/src/editor/EmbeddedFieldStringInput.tsxpackages/visual-editor/src/internal/utils/getFilteredEntityFields.test.tspackages/visual-editor/src/internal/utils/getFilteredEntityFields.tspackages/visual-editor/src/utils/resolveYextEntityField.test.tspackages/visual-editor/src/utils/resolveYextEntityField.tsstarter/localData/dev-location-stream__en__cbafb9cd1c3e63d9814e236ba9181377.jsonstarter/src/dev.config.ts
1. Show base entity numeric fields in the embedded field picker (these already resolved properly but did not appear in the dropdown) 2. Resolve linked entity numeric fields and show them in the embedded field picker 3. Add some test linked entity data https://github.com/user-attachments/assets/332d7389-5ab2-4fab-91d2-6255bcedec7b Will put up a corresponding YSS PR for the RTF drawer
Screen.Recording.2026-07-23.at.11.24.26.AM.mov
Will put up a corresponding YSS PR for the RTF drawer