Skip to content

feat: numeric embedded fields - #1275

Merged
benlife5 merged 2 commits into
mainfrom
numeric-embedded-field
Jul 23, 2026
Merged

feat: numeric embedded fields#1275
benlife5 merged 2 commits into
mainfrom
numeric-embedded-field

Conversation

@benlife5

Copy link
Copy Markdown
Contributor
  1. Show base entity numeric fields in the embedded field picker (these already resolved properly but did not appear in the dropdown)
  2. Resolve linked entity numeric fields and show them in the embedded field picker
  3. Add some test linked entity data
Screen.Recording.2026-07-23.at.11.24.26.AM.mov

Will put up a corresponding YSS PR for the RTF drawer

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@benlife5, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 76800ec5-37a3-44bd-b245-1f052fd4e936

📥 Commits

Reviewing files that changed from the base of the PR and between caf2158 and f67dd0d.

📒 Files selected for processing (1)
  • starter/src/dev.config.ts

Walkthrough

The visual editor now recognizes decimal, float, and integer entity fields as compatible with embedded string inputs. Numeric root fields and nested linked-entity fields can be selected and inserted as embedded expressions. Embedded numeric values are converted to plain strings during resolution. Development schemas, display-name mappings, linked-entity schemas, and local stream data now include numeric location, linked-location, and linked-product fields.

Sequence Diagram(s)

sequenceDiagram
  participant Editor as EmbeddedFieldStringInput
  participant Filter as getEmbeddedStringFilter
  participant Selector as getFieldsForSelector
  participant Resolver as resolveEmbeddedFieldsInString

  Editor->>Filter: Expand string-compatible types
  Filter->>Selector: Request numeric entity-field options
  Selector-->>Editor: Return root and linked numeric fields
  Editor->>Resolver: Resolve embedded numeric expression
  Resolver-->>Editor: Return numeric value as text
Loading

Possibly related PRs

Suggested labels: create-dev-release

Suggested reviewers: jwartofsky-yext, asanehisa, mkilpatrick

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: support for numeric embedded fields.
Description check ✅ Passed The description accurately describes the implemented numeric field picker and test data updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch numeric-embedded-field

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@starter/src/dev.config.ts`:
- Around line 12902-13052: Add the USD option to the options array for
c_linkedProduct.price.currencyCode, matching the existing schema.fields and
c_deliveryFee.currencyCode definition: textValue "USD" with displayName
"USD-United States Dollar". Leave the CTA field typeRegistryId values unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b8d57e2-929f-41b6-838c-235f8447a6c8

📥 Commits

Reviewing files that changed from the base of the PR and between 9423067 and caf2158.

📒 Files selected for processing (8)
  • packages/visual-editor/src/editor/EmbeddedFieldStringInput.test.tsx
  • packages/visual-editor/src/editor/EmbeddedFieldStringInput.tsx
  • packages/visual-editor/src/internal/utils/getFilteredEntityFields.test.ts
  • packages/visual-editor/src/internal/utils/getFilteredEntityFields.ts
  • packages/visual-editor/src/utils/resolveYextEntityField.test.ts
  • packages/visual-editor/src/utils/resolveYextEntityField.ts
  • starter/localData/dev-location-stream__en__cbafb9cd1c3e63d9814e236ba9181377.json
  • starter/src/dev.config.ts

Comment thread starter/src/dev.config.ts
@benlife5
benlife5 merged commit 53622bf into main Jul 23, 2026
16 checks passed
@benlife5
benlife5 deleted the numeric-embedded-field branch July 23, 2026 18:51
benlife5 added a commit that referenced this pull request Jul 23, 2026
1. Show base entity numeric fields in the embedded field picker (these
already resolved properly but did not appear in the dropdown)
2. Resolve linked entity numeric fields and show them in the embedded
field picker
3. Add some test linked entity data



https://github.com/user-attachments/assets/332d7389-5ab2-4fab-91d2-6255bcedec7b

Will put up a corresponding YSS PR for the RTF drawer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants