Skip to content

chore(ci): [DO NOT MERGE] #438 Review gate 核验试验 PR - #439

Closed
yesme wants to merge 3 commits into
mainfrom
agy/review-gate-probe
Closed

yesme wants to merge 3 commits into
mainfrom
agy/review-gate-probe

Conversation

@yesme

@yesme yesme commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

定位与重述

#438 Review gate 核验用临时试验 PR,核验完成后立即关闭并删除分支。

当前生效约束集

业界方案调研

yesme and others added 2 commits October 17, 2026 15:12
#433 的 CI 红了 45 分钟没人发现:作者没等 CI 绿就发「请审」评论,核验席默等,找问题席写「可合」
前没看 CI。所有者要的是能被执行的固定流程,不是 AGENTS.md 里多一句话。

用 GitHub 原生的草稿 / 就绪状态:开 PR 一律 --draft,作者 gh pr ready 就是请审。新 workflow
Review gate 在 ready_for_review 时、以及 Code / Release / PR contract 每次跑完时,看 PR 当前头上三项
必需检查(CI gate、Release gate、PR contract)的最新结论;有一项 failure 或 timed_out,就 gh pr ready
--undo 退回草稿,并留言列出红的检查与链接。只判开着的、就绪的、头与这次运行一致的 PR;不检出 PR 代码。
AGENTS.md「评审与合入」那句「请审之前自己先过一遍」随之改写成这个流程。

Co-authored-by: Claude Code claude-opus-5-5 effort=xhigh <281844019+a-claude-code-bot[bot]@users.noreply.github.com>
Co-authored-by: Antigravity gemini-4-argon effort=high <295901900+an-antigravity-cli-bot[bot]@users.noreply.github.com>
@yesme
yesme marked this pull request as ready for review October 17, 2026 07:18
@yesme
yesme marked this pull request as draft October 17, 2026 07:22
Co-authored-by: Antigravity gemini-4-argon effort=high <295901900+an-antigravity-cli-bot[bot]@users.noreply.github.com>
@yesme
yesme marked this pull request as ready for review October 17, 2026 07:23
@github-actions

Copy link
Copy Markdown

Review gate · 当前头 7219587 的必需检查红了,已退回草稿

作者修好、检查转绿后 gh pr ready 439 再请审。评审席在它重新就绪之前不审;就绪之后对新头重新确认。

@github-actions
github-actions Bot marked this pull request as draft October 17, 2026 07:23
@yesme
yesme marked this pull request as ready for review October 17, 2026 07:25
@github-actions
github-actions Bot marked this pull request as draft October 17, 2026 07:25
@github-actions

Copy link
Copy Markdown

Review gate · 当前头 7219587 的必需检查红了,已退回草稿

作者修好、检查转绿后 gh pr ready 439 再请审。评审席在它重新就绪之前不审;就绪之后对新头重新确认。

@yesme yesme closed this Oct 17, 2026
@yesme
yesme deleted the agy/review-gate-probe branch October 17, 2026 07:27
yesme added a commit that referenced this pull request Oct 17, 2026
Antigravity 在试验 PR #439 上实测出两处、Codex 读出同一处权限问题:
- convertPullRequestToDraft 只给 pull-requests: write 时报 Resource not accessible by integration
  (run 39013169576),加 contents: write 后退草稿与留言成功(run 39013474008)。
- check-runs 的 latest 是每个 check suite 各一条;改描述让 PR contract 重跑转绿后,旧那次的
  failure 还在,#439 被无限退回草稿(run 39013580887)。现在按检查名分组、取 id 最大的那条再判。
  本机对四个真头试过:7219587(先红后绿)不判红,e2e3bb8 照样挑出 Release gate,c19b067 与
  04b71fe(重跑转绿)不判红。

Codex 的 P2 一并收:ready 事件与 workflow_run 用同一个以 PR 号命名的并发组,不再一个 PR 退两次、
留两条言;写之前再看一次 PR 状态与红项,缩小「读完之后变了」的窗口(GitHub 的这个 mutation
不带预期头,关不死,注释里照实写);注释写明只覆盖同仓分支。actionlint 1.7.12 通过。

Co-authored-by: Claude Code claude-opus-5-5 effort=xhigh <281844019+a-claude-code-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant