Repository navigation
chore: clear the Sonar findings on main - #218
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Clears the four issues that turned the Sonar gate red on
main(run40078618341,new_violations= 4). No behaviour changes.KeepAliveInterleavingTests:Assert.Equal(true/false, …)becomesAssert.True(… is true/false)(S2701, from fix: answer a keep-alive while busy #215).IntentRenewalsTests.The_loop_starts_with_the_first_hold_and_renews_on_its_own_period: now verifies the renewal it waited for (S2699, from fix: let heavy work wait without losing attempts #211).HeavyWorkGrain: the privateHold()is renamedSendHold()(S6966, from fix: let heavy work wait without losing attempts #211). It sends a one-way call to the grain on purpose and must not be awaited. The name next toHoldAsyncmade it read as a sync-over-async call.Why
Sonar's gate fails on any new issue. Two of these already shipped in 4.4.7 and two in 4.4.8. None changes what the packages do, so no release follows.
How it was verified
Unit tests:
tests/Stratara.Orleans.Tests355/355.Sonar: dispatched on this branch before the merge.
./scripts/local-gauntlet.shpasses