Improve documentation image builds#56
Open
yawkat wants to merge 23 commits into
Open
Conversation
Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
🚀 Preview deployed to https://cbbaa93a.gridflock-yawk-at.pages.dev |
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
This PR improves reproducibility of documentation image generation by adding a PNG canonicalization step and a CI workflow that verifies just docs leaves committed docs images unchanged.
Changes:
- Add a Pillow-based
canonicalize_png.pyutility and run it duringjust docsimage generation. - Add a GitHub Actions workflow to run
just docswith a checksum-pinned OpenSCAD AppImage and verifydocs/imageshas no diffs. - Add the
pillowdependency to the Python project and lockfile.
Reviewed changes
Copilot reviewed 4 out of 102 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Adds the locked Pillow dependency required for PNG canonicalization. |
pyproject.toml |
Declares pillow as a runtime dependency. |
justfile |
Runs canonicalization on generated docs images during just docs. |
canonicalize_png.py |
Introduces a deterministic PNG rewrite utility using Pillow. |
.github/workflows/docs.yml |
Adds CI verification that just docs output matches committed docs/images using a pinned OpenSCAD AppImage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
Summary
just docsoutput in GitHub Actions using a checksum-pinned OpenSCAD development AppImageValidation
uv sync --frozen --offlinejust test