Skip to content

Task Notifications don't work with multiple assignees #333#340

Open
abrassat wants to merge 7 commits into
xwikisas:masterfrom
abrassat:issue#333
Open

Task Notifications don't work with multiple assignees #333#340
abrassat wants to merge 7 commits into
xwikisas:masterfrom
abrassat:issue#333

Conversation

@abrassat
Copy link
Copy Markdown

@abrassat abrassat commented Mar 17, 2026

  • Added support for sending notifications when a task has multiple assignees

New assignee notifications:
image

@abrassat abrassat self-assigned this Mar 17, 2026
@abrassat abrassat linked an issue Mar 17, 2026 that may be closed by this pull request
@abrassat abrassat requested a review from raphj May 11, 2026 08:57
Copy link
Copy Markdown

@raphj raphj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with the task manager, I'm not in a position to approve but nothing caught my eyes.

It would be nice to remove the code duplication. It if can't be done now, a ticket should be opened.

You wrote that you added test, I'm not seeing them, did you forget to commit them or am I somehow missing them?

@abrassat
Copy link
Copy Markdown
Author

abrassat commented May 11, 2026

I removed the Added Tests comment now. They were added as part of #349

As for the code duplication, are you referring to the duplicated computation of text for notifications/emails? I think I could move it to the page content, and include it in the XObjects (unless the XObjects are executed in a guest context and that breaks the {{include}} macro)

Edit: XObjects don't process the {{include}} macro, so idk how to pull out the common macros.

@abrassat abrassat requested a review from trrenty May 11, 2026 09:40
@abrassat abrassat requested a review from trrenty May 13, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task Notifications don't work with multiple assignees

3 participants