Task Notifications don't work with multiple assignees #333#340
Task Notifications don't work with multiple assignees #333#340abrassat wants to merge 7 commits into
Conversation
* Added tests too
raphj
left a comment
There was a problem hiding this comment.
I'm not really familiar with the task manager, I'm not in a position to approve but nothing caught my eyes.
It would be nice to remove the code duplication. It if can't be done now, a ticket should be opened.
You wrote that you added test, I'm not seeing them, did you forget to commit them or am I somehow missing them?
|
I removed the As for the code duplication, are you referring to the duplicated computation of text for notifications/emails? I think I could move it to the page content, and include it in the XObjects (unless the XObjects are executed in a guest context and that breaks the Edit: XObjects don't process the |
* Pull common code into .vm file
New assignee notifications:
