Skip to content

Preserve exception semantics in shared test comparisons #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agourakis82 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve exception semantics in shared test comparisons #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/test_power.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ struct power_test

void test_power_functions()
{
#if defined(__clang__) && !defined(__FAST_MATH__)
// This test deliberately unmasks floating-point exceptions below.
#pragma clang fp exceptions(strict)
#endif
// pow
{
std::transform(lhs_input.cbegin(), lhs_input.cend(), rhs_input.cbegin(), expected.begin(),
Expand Down
5 changes: 5 additions & 0 deletions test/test_utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,11 @@ namespace detail
template <class T>
T safe_division(const T& lhs, const T& rhs)
{
#if defined(__clang__) && !defined(__FAST_MATH__)
// Comparisons also run with FE_INVALID unmasked in the power tests.
// Do not speculate a division past the zero-denominator guard.
#pragma clang fp exceptions(strict)
#endif
if (rhs == T(0))
{
return (std::numeric_limits<T>::max)();
Expand Down