Repository navigation
Select the principal branch of complex acosh in both half-planes - #1436
Draft
agourakis82 wants to merge 1 commit into
Draft
agourakis82 wants to merge 1 commit into
agourakis82 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complex
acoshselects the wrong branch for inputs in the lower half-plane. For example,(2, -1)produces approximately(-1.46935, 0.507356)instead of(1.46935, -0.507356).Construct the result from the nonnegative imaginary magnitude of
acos(z)and apply the sign of the input imaginary component to the output imaginary component. Add mixed-lane float/double coverage in both half-planes, checking the scalar C++ reference, branch signs, and recovery throughcosh.Validation:
-ffast-math: the same test unit passes.acoshexamples.Addresses the lower-half-plane
acoshexamples in #1432. The real-axis magnitude defect inherited fromacos, other inverse-function defects, nonfinite inputs, and complete architecture coverage remain outside this patch. No claim that #1432 is fully resolved.