Repository navigation
Stub fconv() for the catalog harness - #258
Merged
Merged
Conversation
Engine 28167dd made htslines.c open its files through fconv(), which tools/catalog-lists-test.cpp links without. The encoding job has reded on every pull request since, with "undefined reference to `fconv'". The real one is in the engine's htsconcat.c, which reaches htscore.h and so the coucal submodule the engine checkout does not fetch. A stub is honest here: putting abort() inside it changed nothing, so the harness never calls it, and it exists for the linker alone. Signed-off-by: Xavier Roche <xroche@gmail.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The three-line block answered two questions where one mattered to a reader editing the stub. The header chain behind the real fconv() is not that question. The first commit message blamed engine 28167dd. That is PR #2003 and it only touched src/htsparse.c. The real one is 0885bc79, PR #2001, which added hts_fopen_private() to htslines.c. A `git log -S` in a --depth 1 clone can only answer with HEAD, which is how it got named. Signed-off-by: Xavier Roche <xroche@gmail.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
changed the title
xroche
enabled auto-merge (squash)
October 21, 2026 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine
0885bc79addedhts_fopen_private()tohtslines.c, which opens its file throughfconv(). This harness linkshtslines.cwithout it, so the encoding job fails on every pull request. The stub exists only for the linker. Anabort()placed inside it never fired, because the harness opens the catalogs itself.