Repository navigation
Various bug fixes - #185
Merged
Merged
Conversation
Owner
|
For this one: adc88b6 It's simpler just to change definition of 'void input_error()' to 'int input_error' and return 0. I can do this manually. Can you remove this PR item? |
Contributor
Author
|
But the patch is the right approach. Returning What is your concern? The work is done and touching many files is not necessarily a bad thing. If you insist, I am going to adapt the commit. It provides improvements for Doxygen comments in |
marker[perm[i]] was read before testing perm[i] >= n, and negative entries were never rejected, so an invalid permutation caused an out-of-bounds read instead of the intended error message.
input_error() is defined as void in input_error.c, but slu_util.h, sp_ienv.c and the bundled CBLAS sources declared it as returning int. Calling a function through a declaration with a different return type is undefined behaviour. No caller uses the return value.
fp was only set by parse_command_line when -f was given, so running a driver with a non-LA matrix type and no -f passed an uninitialized FILE pointer to *readhb.
A debugging leftover switched dlinsolx to dreadMM, so it rejected the Harwell-Boeing input (g20.rua) that the comment, the other precisions and the README use.
gruenich
force-pushed
the
feature/opus-identified-bugs
branch
from
October 22, 2026 21:13
2d0c3f8 to
a58484b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked Claude to identify top bugs which are certain, small fix, and easy to verify. I selected the ones I was able to confirm and added some additional changes.