Skip to content

[ci] Add AddressSanitizer build and test - #179

Closed
gruenich wants to merge 1 commit into
xiaoyeli:masterfrom
gruenich:feature/ci-address-sanitizer
Closed

gruenich wants to merge 1 commit into
xiaoyeli:masterfrom
gruenich:feature/ci-address-sanitizer

Conversation

@gruenich

@gruenich gruenich commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

AddressSanitizer reveals real memory issues. Marking this pull request as draft until the underlying problem is solved.

@gruenich
gruenich marked this pull request as draft October 17, 2026 15:51
@xiaoyeli

Copy link
Copy Markdown
Owner

I see a lot of failures: https://github.com/xiaoyeli/superlu/actions/runs/39046868270/job/117437223566
Are these real memory problems?
I usually run valgrind manually.

@gruenich

Copy link
Copy Markdown
Contributor Author

I asked Claude Code and got some fixes. Give a litte time to brush these up and get a proper merge request.

@gruenich

gruenich commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Are these real memory problems?

They are real, see #180. Some in the SuperLU library itself, other in the testing code or the examples. The two latter ones are also important, as users start with these and adopt it for their use cases.

Once this is done, I am looking for

  1. adding UBSan (UndefinedBehaviorSanitizer), see [ci] Add UndefinedBehaviorSanitizer to AddressSanitizer job #184
  2. removing SuperLU's memory debbung code, as it is inferior to external tooling like Sanitizers and Valgrind, see Remove code for memory debugging #181
  3. making examples optional part of testing. Better coverage and we will detect regressions in examples.

@gruenich

Copy link
Copy Markdown
Contributor Author

This pull request became part of #180

@gruenich gruenich closed this Oct 18, 2026
@gruenich
gruenich deleted the feature/ci-address-sanitizer branch October 18, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants