Conversation
Found by live acceptance: PR worktree provisioning failed with libgit2 'no TLS stream available' on a machine behind a local proxy, and libgit2 fetch has no credential-helper integration for private repositories. The network fetch now shells out to the configured tools.git (honors credential helpers and proxies); libgit2 keeps the local operations (ref lookup, worktree add).
libgit2's worktree add rejects remote-tracking references ('reference is
not a branch'); the system git creates the generation-scoped local branch
and the worktree in one step (-B for idempotent retries). git2 remains for
local inspection only.
Owner
Author
|
Superseded: commits cherry-picked into #142 (single acceptance-fix PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by live acceptance on v0.3.0 (machine behind a local proxy, private repo): PR materialization failed in libgit2 — first
no TLS stream available(fetch), thenreference is not a branch(worktree add rejects remote-tracking refs) — parking the PR assignment inblocked.Both network/checkout mutations now shell out to the configured
tools.git(credential helpers + proxies work there):git fetchfor the head ref,git worktree add -Bfor the generation-scoped branch + worktree. libgit2 keeps local read-only inspection. fmt/check/clippy/test green.