Strip source-buffer properties from grabbed region context#696
Merged
Conversation
agent-shell--get-region-context built its single-line file-link preview with buffer-substring, and agent-shell--get-numbered-region built its numbered preview the same way. buffer-substring copies all text properties, so when the source buffer was a markdown-mode or poly-markdown buffer, markdown-mode's font-lock leaked into the grabbed context: the emphasis markup characters carried 'invisible markdown-markup' + 'markdown-markup-face' and the enclosed text carried italic faces. _hello_world_ then showed up in the compose buffer as helloworld (underscores hidden, inner text italic) - the same intraword-underscore symptom the response renderer was already fixed to avoid. Use buffer-substring-no-properties for both preview paths so the context carries plain text and no foreign-mode styling.
Owner
|
Thanks for the PR! Wouldn't we want to at least keep |
Contributor
Author
Yes, it's a good idea to keep some faces, I added a custom buffer-substring function to keep both. |
xenodium
approved these changes
Jul 4, 2026
xenodium
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR and follow-up changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent-shell--get-region-context built its single-line file-link preview with
buffer-substring, andagent-shell--get-numbered-regionbuilt its numbered preview the same way.buffer-substringcopies all text properties, so when the source buffer was amarkdown-modeorpoly-markdownbuffer,markdown-mode's font-lock leaked into the grabbed context: the emphasis markup characters carried'invisible markdown-markup'+'markdown-markup-face'and the enclosed text carried italic faces._hello_world_then showed up in the compose buffer ashelloworld(underscores hidden, inner text italic) — the same intraword-underscore symptom the response renderer was already fixed to avoid.Use
buffer-substring-no-propertiesfor both preview paths so the context carries plain text and no foreign-mode styling.Checklist
M-x checkdocandM-x byte-compile-file.