Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
BDX-1590.
Append Flight dictionary delta frames to the existing dictionary and retain replacement behavior. Backport the reviewed Arrow 20 correction from PR32 to the Java19 source used by Dremio.
Real Java19 failures also required sliced offset and child-range fixes, empty-target handling, checked dictionary indices before narrowing, and the struct decoder's dictionary cardinality. The dependency versions and public APIs stay unchanged.
Checks
The committed 16-module Java reactor and formatting, style, dependency, and compiler checks pass. Full vector tests have 2,310 passing executions and 8 existing skips. Flight core has 139 passing cases and 18 existing skips. The same 22 framed regressions pass with committed Netty and Unsafe jars and expose 19 failures with the original jars. Allocation returns to zero.
Independent source, artifact, and behavior review passes at this commit. An independent nested-list and forced-allocation-failure probe also passes with cleanup under both allocators. Native distribution, remote publication, Dremio consumption, and DaaS certification remain separate gates. This dependency unit does not complete BDX-1590, M1, or M2.
Dependency
The base is the exact Dremio Java19 predecessor
7c673d7d48e16290a4693a5dbfe73a9abda8cff3. This is a focused historical dependency branch. The program has not merged into trunk or activated production features.