Skip to content

fix(flight): BDX-1590 append dictionary deltas #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xborder wants to merge 2 commits into from
Closed

fix(flight): BDX-1590 append dictionary deltas #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a71d4f4
BDX-1590: Append Flight dictionary deltas
xborder Oct 14, 2026
86fbde3
BDX-1590: Append Null vector counts
xborder Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions flight/flight-core/src/main/java/org/apache/arrow/flight/FlightStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import org.apache.arrow.vector.types.pojo.Field;
import org.apache.arrow.vector.types.pojo.Schema;
import org.apache.arrow.vector.util.DictionaryUtility;
import org.apache.arrow.vector.util.VectorBatchAppender;
import org.apache.arrow.vector.validate.MetadataV4UnionChecker;

/** An adaptor between protobuf streams and flight data streams. */
Expand Down Expand Up @@ -291,13 +292,21 @@ public boolean next() {
}

final FieldVector vector = dictionary.getVector();
final VectorSchemaRoot dictionaryRoot =
new VectorSchemaRoot(
Collections.singletonList(vector.getField()),
Collections.singletonList(vector),
0);
final VectorLoader dictionaryLoader = new VectorLoader(dictionaryRoot);
dictionaryLoader.load(arb.getDictionary());
if (arb.isDelta()) {
try (FieldVector deltaVector = vector.getField().createVector(allocator)) {
final VectorSchemaRoot deltaRoot = VectorSchemaRoot.of(deltaVector);
new VectorLoader(deltaRoot).load(arb.getDictionary());
VectorBatchAppender.batchAppend(vector, deltaVector);
}
} else {
final VectorSchemaRoot dictionaryRoot =
new VectorSchemaRoot(
Collections.singletonList(vector.getField()),
Collections.singletonList(vector),
0);
final VectorLoader dictionaryLoader = new VectorLoader(dictionaryRoot);
dictionaryLoader.load(arb.getDictionary());
}
}
return next();
} else {
Expand Down
Loading
Loading