Skip to content

fix: keep player colors and palette on rematch - #838

Open
wyne wants to merge 1 commit into
mainfrom
claude/project-thread-dlepwn
Open

wyne wants to merge 1 commit into
mainfrom
claude/project-thread-dlepwn

Conversation

@wyne

@wyne wyne commented Nov 21, 2026

Copy link
Copy Markdown
Owner

Rematch created players without a color and reset the game palette, so rows showed the grey fallback. It now copies each player's color (falling back to the palette) and the game's palette. Added a test.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017uLVvdMCUpqLtFJhs1bhHo
@github-actions

Copy link
Copy Markdown
Contributor

Coverage after merging claude/project-thread-dlepwn into main will be

81.36%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
redux
   GamesSlice.ts76.23%62.50%76.92%83.46%100, 117, 122–123, 123, 123, 135–136, 136, 136, 138, 147, 158, 178, 210, 235–237, 240, 251, 254, 287, 294, 296, 299–301, 368, 381, 390–391, 391, 391, 397, 397, 397–398, 400, 402–403, 406, 406, 406, 406, 406–407, 410, 419, 89
   PlayersSlice.ts88.54%94.44%86.36%87.50%118, 120, 128, 48, 65–66, 83–84
   ScoringRules.ts99.03%97.67%100%100%112
   SettingsSlice.ts76.92%87.50%70.83%78.79%114, 126, 132, 140, 146, 81, 90, 93
   backup.ts79.70%77.55%88.89%81.19%109, 109, 136–138, 146, 191–192, 194, 208–212, 214, 214, 214–215, 220, 223, 234, 244–245, 264, 60–65, 67, 70, 70–72, 72, 72–73, 73, 73, 75–76, 78–80, 82–83, 83–85, 92–93
   hooks.ts100%100%100%100%
   scoreUtils.ts94.74%87.50%100%100%15
   selectors.ts98.13%95%100%100%14, 93
   store.ts78.13%55%91.67%87.50%13, 13, 13, 132, 14, 14, 14–16, 24, 24, 41, 85
   testStore.ts0%100%0%0%11–15, 20–23, 25, 42–44, 5
src
   Analytics.ts100%100%100%100%
   AnalyticsEvents.ts100%100%100%100%
   ColorPalette.ts100%100%100%100%
   Logger.ts91.23%87.50%81.82%94.74%14–15, 22
   Navigation.tsx77.46%65.52%66.67%90.91%100, 140, 144, 144–145, 152, 152, 154, 154, 160–161, 78, 82
   constants.ts100%100%100%100%
   iconTypes.ts0%100%100%0%10–11, 7–9
   platform.ts100%100%100%100%
   savePhoto.ts0%100%0%0%12, 14–15, 9
   theme.ts95.83%88.89%100%100%100
src/components
   EditGame.tsx79.63%75%66.67%84.85%36, 50, 63–64, 87, 87, 87–88
   FloatingActionButton.tsx92.86%100%87.50%94.44%97
   GameListItem.tsx93.37%85.23%100%100%171, 176, 193, 215, 239, 253, 27, 305, 33, 60, 67, 86–87
   GestureHintToast.tsx95.12%77.78%100%100%67, 82
   GestureNudge.tsx100%100%100%100%
   GestureNudgeContext.tsx88.52%90.91%66.67%94.74%56, 77–78
   LockedGameHint.tsx100%100%100%100%
   LockedHintContext.tsx97.14%100%90%100%
   MenuOpenContext.tsx87.50%100%66.67%100%
   PlayerListItem.tsx0%0%0%0%123, 123, 134, 24, 32–34, 34, 34–38, 40, 40, 40, 40, 40–41, 41, 41–42, 42, 42, 44–45, 56, 63–64, 66, 72–73, 76, 79, 82–83, 90, 93, 93, 96, 96, 96–97, 99
   ScoreLogTable.tsx91.89%81.48%100%97.06%69, 71, 73, 73, 82, 88
   ScoringRow.tsx100%100%100%100%
   SectionLabel.tsx100%100%100%100%
   SplashOverlay.tsx0%0%0%0%22–24, 24, 24, 26–28, 30, 32–33, 35, 37, 40, 40, 40, 43, 49, 53, 58, 74
src/components/AppInfo
   RotatingIcon.tsx0%0%0%0%18–19, 21–24, 26, 28–30, 37–38, 40, 40, 40–41, 44, 44, 44–48, 51, 53–54, 59
   SeedData.ts11.11%0%0%15%100, 102–103, 105, 107–109, 111–113, 115, 121, 124, 132, 132, 135, 135, 139–140, 142–143
src/components/BigButtons
   BigButton.tsx0%0%0%0%19, 19–21, 23, 29, 29, 33, 33–34, 34, 57
src/components/Boards
   ListBoard.tsx88.31%77.05%83.33%98.67%128, 128, 197, 227, 232, 245, 248, 34, 38, 65–66, 89, 89, 93, 97
   PlayerTile.tsx0%0%0%0%100, 100, 118, 18, 21, 37, 49–52, 52, 52–53, 53, 53, 53, 53–54, 54, 54–56, 56, 56, 58–60, 60, 60, 62, 65, 65, 69–70, 73–74, 76, 78, 78, 78, 78, 78–79, 79, 79, 79, 79, 83, 83, 83, 85, 97, 97
   TileBoard.tsx98.80%96.30%100%100%35
src/components/Buttons
   AppSettingsButton.tsx59.38%50%50%65%37–38, 42–44, 47, 53, 53, 56
   GameOptionsButton.tsx55.62%49.15%65.38%57.14%101–102, 124, 124, 124, 124, 124, 124, 124, 124, 126–127, 129–130, 132–133, 135–138, 140–142, 144–145, 147–148, 153–155, 183, 187, 191–194, 197, 201, 203–204, 204, 204, 206–207, 207, 207, 217, 224, 227, 231, 231, 231, 231, 233, 233, 266, 275, 295, 313, 315, 321, 321, 321, 321, 75, 86
   HeaderButton.tsx81.82%60%100%100%19–20
src/components/ColorPalettes
   ColorSelector.tsx100%100%100%100%
   PalettePreview.tsx0%0%0%0%10–12, 14, 19, 19, 25
   PaletteSelector.tsx0%0%0%0%13, 15–18, 20, 22,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants