Skip to content

fix: keep player colors in Dial mode for players saved without a color - #832

Open
wyne wants to merge 1 commit into
mainfrom
claude/project-thread-w0joxk
Open

wyne wants to merge 1 commit into
mainfrom
claude/project-thread-w0joxk

Conversation

@wyne

@wyne wyne commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Players from older versions have no stored color. Tile mode falls back to the game palette by seat, but the Dial list rows and Dial overlay fell back to hard-coded grey (#555 / #444), so older games went greyscale in Dial mode.

Adds selectPlayerColor (stored color, else seat palette color) and uses it in ListBoard and DialOverlay, with tests.


Generated by Claude Code

… mode

Players created before colors were stored per player have no color field.
Tile mode already fell back to the game's palette by seat, but the Dial list
rows and the Dial overlay fell back to hard-coded grey, so older games
turned greyscale after switching to Dial.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017uLVvefpw6mGTXuipKxHZg
@wyne wyne self-assigned this Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Coverage after merging claude/project-thread-w0joxk into main will be

81.40%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
redux
   GamesSlice.ts76.76%63.24%77.50%83.46%100, 117, 122–123, 123, 123, 135–136, 136, 136, 138, 147, 158, 178, 210, 235–237, 252, 285, 292, 294, 297–299, 366, 379, 388–389, 389, 389, 395, 395, 395–396, 398, 400–401, 404, 404, 404, 404, 404–405, 408, 417, 89
   PlayersSlice.ts88.54%94.44%86.36%87.50%118, 120, 128, 48, 65–66, 83–84
   ScoringRules.ts99.03%97.67%100%100%112
   SettingsSlice.ts76.92%87.50%70.83%78.79%114, 126, 132, 140, 146, 81, 90, 93
   backup.ts79.70%77.55%88.89%81.19%109, 109, 136–138, 146, 191–192, 194, 208–212, 214, 214, 214–215, 220, 223, 234, 244–245, 264, 60–65, 67, 70, 70–72, 72, 72–73, 73, 73, 75–76, 78–80, 82–83, 83–85, 92–93
   hooks.ts100%100%100%100%
   scoreUtils.ts94.74%87.50%100%100%15
   selectors.ts96.03%90.20%100%100%108, 15, 59–61
   store.ts78.13%55%91.67%87.50%13, 13, 13, 132, 14, 14, 14–16, 24, 24, 41, 85
   testStore.ts0%100%0%0%11–15, 20–23, 25, 42–44, 5
src
   Analytics.ts100%100%100%100%
   AnalyticsEvents.ts100%100%100%100%
   ColorPalette.ts100%100%100%100%
   Logger.ts91.23%87.50%81.82%94.74%14–15, 22
   Navigation.tsx77.46%65.52%66.67%90.91%100, 140, 144, 144–145, 152, 152, 154, 154, 160–161, 78, 82
   constants.ts100%100%100%100%
   iconTypes.ts0%100%100%0%10–11, 7–9
   platform.ts100%100%100%100%
   savePhoto.ts0%100%0%0%12, 14–15, 9
   theme.ts95.83%88.89%100%100%100
src/components
   EditGame.tsx79.63%75%66.67%84.85%36, 50, 63–64, 87, 87, 87–88
   FloatingActionButton.tsx92.86%100%87.50%94.44%97
   GameListItem.tsx93.37%85.23%100%100%171, 176, 193, 215, 239, 253, 27, 305, 33, 60, 67, 86–87
   GestureHintToast.tsx95.12%77.78%100%100%67, 82
   GestureNudge.tsx100%100%100%100%
   GestureNudgeContext.tsx88.52%90.91%66.67%94.74%56, 77–78
   LockedGameHint.tsx100%100%100%100%
   LockedHintContext.tsx97.14%100%90%100%
   MenuOpenContext.tsx87.50%100%66.67%100%
   PlayerListItem.tsx0%0%0%0%123, 123, 134, 24, 32–34, 34, 34–38, 40, 40, 40, 40, 40–41, 41, 41–42, 42, 42, 44–45, 56, 63–64, 66, 72–73, 76, 79, 82–83, 90, 93, 93, 96, 96, 96–97, 99
   ScoreLogTable.tsx91.89%81.48%100%97.06%69, 71, 73, 73, 82, 88
   ScoringRow.tsx100%100%100%100%
   SectionLabel.tsx100%100%100%100%
   SplashOverlay.tsx0%0%0%0%22–24, 24, 24, 26–28, 30, 32–33, 35, 37, 40, 40, 40, 43, 49, 53, 58, 74
src/components/AppInfo
   RotatingIcon.tsx0%0%0%0%18–19, 21–24, 26, 28–30, 37–38, 40, 40, 40–41, 44, 44, 44–48, 51, 53–54, 59
   SeedData.ts11.11%0%0%15%100, 102–103, 105, 107–109, 111–113, 115, 121, 124, 132, 132, 135, 135, 139–140, 142–143
src/components/BigButtons
   BigButton.tsx0%0%0%0%19, 19–21, 23, 29, 29, 33, 33–34, 34, 57
src/components/Boards
   ListBoard.tsx88.16%76.27%83.33%98.67%128, 128, 197, 227, 232, 245, 248, 34, 38, 65–66, 89, 89, 93, 97
   PlayerTile.tsx0%0%0%0%100, 100, 118, 18, 21, 37, 49–52, 52, 52–53, 53, 53, 53, 53–54, 54, 54–56, 56, 56, 58–60, 60, 60, 62, 65, 65, 69–70, 73–74, 76, 78, 78, 78, 78, 78–79, 79, 79, 79, 79, 83, 83, 83, 85, 97, 97
   TileBoard.tsx98.80%96.30%100%100%35
src/components/Buttons
   AppSettingsButton.tsx59.38%50%50%65%37–38, 42–44, 47, 53, 53, 56
   GameOptionsButton.tsx55.62%49.15%65.38%57.14%101–102, 124, 124, 124, 124, 124, 124, 124, 124, 126–127, 129–130, 132–133, 135–138, 140–142, 144–145, 147–148, 153–155, 183, 187, 191–194, 197, 201, 203–204, 204, 204, 206–207, 207, 207, 217, 224, 227, 231, 231, 231, 231, 233, 233, 266, 275, 295, 313, 315, 321, 321, 321, 321, 75, 86
   HeaderButton.tsx81.82%60%100%100%19–20
src/components/ColorPalettes
   ColorSelector.tsx100%100%100%100%
   PalettePreview.tsx0%0%0%0%10–12, 14, 19, 19, 25
   PaletteSelector.tsx0%0%0%0%13, 15–18, 20, 22,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants