Repository navigation
fix: show each gesture hint once, ever, and fix swipe/tap nudges - #824
Conversation
The first-use toast compared the game's gesture with the single last-used gesture, so switching between games with different gestures brought it back every time, and Got it was forgotten on restart. Save every gesture the player has scored with or dismissed, and only show the toast for gestures missing from that list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017uLVveP5MpW2jCcYwgRQCp
The miss was reported from the pan's onEnd, which only fires after the pan activates. A tap that doesn't move never activates it, so the swipe nudge never showed. Report from onFinalize, which runs for every touch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017uLVveP5MpW2jCcYwgRQCp
|
Coverage after merging claude/project-thread-hzqyww into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
A touch that drags 20pt or more and ends without scoring counts as a tap mode miss. Two in a row show "Tap the top half of a tile to add, the bottom half to subtract." Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017uLVveP5MpW2jCcYwgRQCp
|
Coverage after merging claude/project-thread-hzqyww into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
wyne
left a comment
There was a problem hiding this comment.
Found one issue in the new tap-mode nudge detection (inline).
Validation: all 91 tests in the eight targeted settings, migration, backup, hint, and interaction suites passed. The subset run exited nonzero only because global coverage thresholds apply to the entire app. A separate temporary reproduction using React Native's real Pressability state machine confirmed that one ongoing touch can report two misses and then successfully score on release. The temporary test was removed; no source changes remain.
onPressOut fires when the finger leaves the press area mid-touch, so one touch that wandered out and back could report two misses and then score. Track the whole touch with onTouchStart/End on the tile's inner view and count at most one miss, after release, only if the touch didn't score. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017uLVveP5MpW2jCcYwgRQCp
|
Coverage after merging claude/project-thread-hzqyww into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Instead of seeding only the last gesture used, mark the gesture of every saved game with a score as learned, so returning players don't see first-use hints for gestures they already know. Settings can't see games during migration, so it runs once after rehydration (and after restoring an older backup). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017uLVveP5MpW2jCcYwgRQCp
|
Coverage after merging claude/project-thread-hzqyww into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
wyne
left a comment
There was a problem hiding this comment.
Final recheck of 3d0a905: no new actionable findings. Reviewed the new saved-game inference, the post-rehydration backfill, preservation of existing learned lists, and the backup restore path. The previously reported touch-lifecycle issue remains fixed.
Validation: all 122 tests in 10 targeted suites pass; tsc --noEmit and ESLint for the files changed since the previous review pass. No source changes made.
Merging this PR bumps `package.json` to the version below, tags the merge commit, and publishes the GitHub release. `app.config.js` reads its `version` from `package.json`, so the shipped app version follows automatically. --- ## [3.6.1](v3.6.0...v3.6.1) (2026-11-05) ### Bug Fixes * show each gesture hint once, ever, and fix swipe/tap nudges ([#824](#824)) ([9cc2659](9cc2659)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
The first-use gesture toast now shows once per gesture. Scoring with a gesture or tapping Got it / How it works saves it to a persisted
learnedInteractionTypeslist. Switching between games with different gestures, or restarting the app, no longer brings the toast back.GestureHintContextonEnd, which only fires once the pan activates. It's now reported fromonFinalize.