Skip to content

fix: correct stale extproc header names in examples docs - #24

Merged
wrossmorrow merged 1 commit into
mainfrom
fix/examples-header-names
Oct 28, 2026
Merged

wrossmorrow merged 1 commit into
mainfrom
fix/examples-header-names

Conversation

@wrossmorrow-pi-bot

Copy link
Copy Markdown
Contributor

What

Corrects stale ext_proc header names in the README examples section, aligning them with the
names now used by the SDK and the Go/Rust SDKs.

Changes

  • x-extproc-started → x-extproc-started-ns (HTTP sample + JSON echo key)
  • x-extproc-finished → x-extproc-finished-ns (HTTP sample)
  • x-extproc-response-seen: true → x-extproc-response: seen (HTTP sample; aligned with the
    trivial example's x-extproc-response marker)
  • X-Extproc-Request-Seen → X-Extproc-Request (JSON echo key; aligned with the trivial example)
  • X-Extproc-Started → X-Extproc-Started-Ns (JSON echo key)
  • x-extproc-processors → x-extproc-names (No-op prose; the SDK adds x-extproc-names)
  • X-Echo-Delay → ?delay=<int> query param (Dedup prose; aligned with Go/Rust)
  • example source path corrected to src/main/java/com/github/wrossmorrow/extproc/processors

Notes

  • The missing router example/processor was verified to already exist, be wired into
    docker-compose.yaml/envoy.yaml, and be documented in the README, so no code change was needed
    there.

Verification

./gradlew clean build

@wrossmorrow
wrossmorrow merged commit 9637e76 into main Oct 28, 2026
4 checks passed
@wrossmorrow
wrossmorrow deleted the fix/examples-header-names branch October 28, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant