Repository navigation
fix: correct envoy cluster type and wire compose build for extproc image - #20
Merged
wrossmorrow merged 2 commits intoOct 28, 2026
Merged
Conversation
- envoy.yaml: fix invalid cluster discovery type on the 'router' cluster, LOGICAL_D_NS -> LOGICAL_DNS, which caused envoy to fail bootstrap config validation and exit. - docker-compose.yaml: add missing build context to the extproc services so 'docker compose up --build' builds the local image from the freshly built jar instead of pulling a stale published image (ClassNotFoundException).
wrossmorrow
approved these changes
Oct 28, 2026
wrossmorrow
deleted the
fix/run-example-envoy-config-and-compose-build
branch
October 28, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
./gradlew clean build && docker compose up --buildexample run failing with two errors.1. Envoy bootstrap config failure (fatal)
envoy.yamlused an invalid cluster discovery type on theroutercluster:LOGICAL_D_NSis not a validenvoy.config.cluster.v3.Cluster.DiscoveryTypevalue; the correct value isLOGICAL_DNS. Envoy aborted bootstrap config validation (static_resources.clusters[10].type) and exited, so no extproc could ever be reached.Fix:
type: LOGICAL_DNSon theroutercluster.2. ExtProc
ClassNotFoundExceptionfor example processors (stale image)The compose file wires each extproc example via
-Dextproc.class=com.github.wrossmorrow.extproc.processors.<X>RequestProcessor.The freshly built jar (
./gradlew clean build) does contain and successfully load these classes (verified by running the jar locally), and the source packagecom.github.wrossmorrow.extproc.processorsis current. However, the stack trace frames (ExternalProcessorServer.getProcessorFromPropertiesat line 210,ExternalProcessorServer.mainat line 222) don't match the current source (where those methods now live at lines 289/300), confirming the container was running an older jar.Root cause: the
docker-compose.yamlextproc services declare only animage:(defaulting to the publishedghcr.io/wrossmorrow/envoy-extproc-sdk-java:${IMAGE_TAG:-local}) with nobuild:context.docker compose up --buildtherefore never rebuilds the extproc image — it just pulls the published one — which is stale and predates the example processors, hence theClassNotFoundException.Fix: added the missing
build:context to all ten extproc services sodocker compose up --buildbuilds the image from the locally built jar (build/libs/extproc-*.jar, per theDockerfile).Testing
./gradlew clean build -x test— BUILD SUCCESSFULdocker compose config— valid YAMLDocker was unavailable in the authoring sandbox, so the full compose stack should be re-verified with a real
docker compose up --buildrun.Closes the run-example failure reported in the README quickstart.