ci: remove redundant workshop dependency and build identity checks - #405
Merged
Merged
Conversation
First phase of removing Python from CI. Port the workshop-rs dependency contract check (and its matcher unit test), the dist build-identity writer, and the build-identity verifier to bash + jq, which GitHub-hosted runners provide on every OS. Behavior and output match the Python originals; consumer lists in error messages are now sorted. The dist/release scripts still use Python and move in a later phase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178vQfKDP4QsRd2Kykm3FZ4
Keep CI steps free of bash/Python helper scripts where possible: - Move the workshop-rs dependency contract check into a Rust integration test in wright-analyzer (a direct workshop-rs consumer), so it runs in the existing stable and MSRV `cargo test` gates instead of a dedicated CI step. - Remove the dist build-identity writer/verifier. Artifacts are already scoped to the workflow run; dist-validation now only restores the executable bit on non-Windows runners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178vQfKDP4QsRd2Kykm3FZ4
Teakowa
changed the title
Contributor
Author
|
This doesn't look like a failure caused by this PR:
No fix exists or is needed in this PR. CI for the current head Generated by Claude Code |
workshop-rs is pinned once in [workspace.dependencies], every consumer inherits it with `workspace = true`, no other dependency pulls in workshop-rs, and CI resolves with --locked. The separate contract check no longer guards anything those already guarantee, so remove it instead of porting it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178vQfKDP4QsRd2Kykm3FZ4
Teakowa
changed the title
Teakowa
marked this pull request as ready for review
September 24, 2026 07:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the first step toward CI steps that are only
uses:actions and single commands. It removes two script-backed checks that no longer guard anything real. It adds no replacement code (+3 / −272).check-workshop-dependency.pyplus its unittest, and theCheck Workshop dependencystep): removed.[workspace.dependencies], by exactrev.workspace = true.cargo tree -i workshop-rsshows no transitive path that could pull in a second copy.--locked.write-build-identity.py/verify-build-identity.pyand thewright-dist.build.jsonartifact): removed.dist-validationnow only runschmod +xon the binaries, on non-Windows runners.Earlier commits on this branch tried porting these checks to bash and then to a Rust test. Both were dropped, and the final diff is deletions only. Release-side identity files (
dist/wright-*.build.jsoninrelease.yml) are unchanged.Follow-ups (separate PRs, pending decisions)
release.yml: replace the inline version bump, packaging, checksum and channel publishing with existing actions (release-please, upload-rust-binary-action, Homebrew/WinGet publishers).dist-validation: consider generatingdist/manifests only at release time (this removesverify-dist.py), and moving channel install tests to post-release smoke checks.scripts/test-lpp-integration.sh, which is threecargo testlines, into the workflow YAML.Validation
git diff --checkis clean.wright-dist.build.jsoninci.ymlor the docs.🤖 Generated with Claude Code
https://claude.ai/code/session_0178vQfKDP4QsRd2Kykm3FZ4