fix(analyzer): replace serde_yaml with yaml_serde - #361
Conversation
Teakowa
left a comment
There was a problem hiding this comment.
crates/wright-analyzer/tests/yaml_contract.rs: most of this new contract suite duplicates the existing analyzer coverage established by #310 — declarative YAML loading/execution, project config parsing/options, severity behavior, and unknown-option rejection are already protected in tests/registry.rs. #358 allows adding or retaining focused compatibility coverage, so the parser swap does not justify a second end-to-end copy of the same contract without an independent failure mode. This adds maintenance cost and can let the two suites drift while testing the same assumptions. Please remove the duplicated cases and keep only migration-specific coverage that exercises a genuinely uncovered YAML behavior, if any.
|
已根据 review 修正:
修正提交: |
Summary
serde_yamlworkspace dependency with the maintainedyaml_serdefork from the YAML OrganizationFixes #358
Verification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-targets --all-featurescargo test -p wright-analyzer --test yaml_contractserde_yamlorunsafe-libyamldependency/call site remainsserde_yaml v0.9.34+deprecatedin the dependency graph