test(element-count): cover player-variable target costs - #310
Merged
Merged
Conversation
Teakowa
requested changes
Sep 26, 2026
Teakowa
left a comment
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
One blocking correctness issue in variable-target counting.
e54-bot
changed the title
Teakowa
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Stop Chasing Player VariableandSet Player Variable At Index, including their direct-argument reduction.Context
mainthrough fix(analysis): count elements the way the client-checked OverPy counter does #308, which closed Element count is about 37% below the client on a real project #305. This PR adds the focused regression requested in review.Validation
cargo test -p workshop-rs(231 library tests, 9 catalog-generator tests, and 103 integration tests passed; 3 performance tests ignored).cargo clippy --locked --workspace --all-targets -- -D warningscargo fmt --check