fix(parser): preserve Team constants in Color slots - #307
Merged
Merged
Conversation
Teakowa
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #306
Changes
Team 1/Team 2as Team identities in Color-typed slots when that member also exists in the Color catalog. ExplicitColor(Team 2)remains a Color identity.Team(/Hero(/Button(/Color(wrapper counts on the pinned OverPy-generated real-project fixtures.Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targets— passed; 3 performance benchmarks ignored by the suitecargo run -p workshop-rs --bin workshop-catalog-gen -- check— passed (528 entries, 52 enum domains, 15 locales)git diff --checkRuntime evidence still needed
The Issue also asks whether
a && b && c && dand nestedAnd(And(And(a, b), c), d)have the same element cost in the Overwatch client. That comparison was not measured because this host has no Overwatch client installed or running. The parser/emission acceptance criteria pass; this runtime measurement remains open.