fix(emitter)!: emit constant wrappers and yes/no settings the way the client accepts them - #303
Merged
Merged
Conversation
… client accepts them Hero, Button, Color and Map constants are always written with their wrapper and Team members bare, in every position, emit path and locale, matching pinned OverPy 9.7.10. Lobby settings that take yes/no are written Yes/No. The ten zh-CN action spellings that differed from OverPy now emit the OverPy spelling and keep the old one as a parse alias. Adds docs/wrapper-forms.md and regression coverage. Fixes #302
Teakowa
requested changes
Sep 26, 2026
Teakowa
left a comment
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
One blocking test-coverage issue.
The fixture regression filtered on non-existent case ids and matched nothing. It now selects ai-pve and bastion and fails if either is missing. Exercising it showed the pinned OverPy spelling Domina was not the emitted hero alias.
Teakowa
requested changes
Sep 26, 2026
Teakowa
left a comment
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
The zero-case bug is fixed and CI is green, but the fixture AC is now being narrowed in the test.
Restores the whole-fixture no-added-token check. Settings numbers keep their shortest spelling, hero settings prefer the producer alias, and indexed player-variable actions split the player and name pair again.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302
Rule
Keyed on the constant's domain, identical for every emit path and locale (docs/wrapper-forms.md):
Hero/Button/Color/Mapalways wrapped,Teammembers bare. Evidence: pinned OverPy 9.7.10 probe in en-US and zh-CN across Team-, Hero-, Array-, Compare- and Custom String-argument positions (ADR-0014 "deliberate upstream emission rule").Changes
force_hero_constructorsconversion-only path and the locale-dependent Hero wrapping.KeyKind::YesNoforAllow Players Who Are In QueueandSwap Teams After Match; adds theYestoken (from the__yes__export entry).ai-pve,bastion). Two corpus test inputs updated to the new forms.Notes
Game Mode(...)is a catalog value function and is preserved as parsed; not part of the wrapper rule.Team(...)are no longer written.Validation
fmt, clippy -D warnings,
cargo test --workspace --all-targets,workshop-catalog-gen check,git diff --checkall pass locally.