test(compiler): cover native Workshop identities at the emission boundary - #400
Merged
Merged
Conversation
…dary Set Player Allowed Heroes and the other identities retired by workshop-rs 0.8.0 are emitted under their native names and reparse under the canonical catalog. Refs #399
Teakowa
approved these changes
Sep 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainalready pinsworkshop-rs =0.8.0and emits native identities; provider 0.1.58 (built on 0.6.2) is what emittedSet Allowed Heroes. This adds the regression test the issue asks for:setAllowedHeroes,startForcingHero,startForcingThrottle,stopForcingThrottle,stopChasingVariableandisFiringSecondaryFirecompile to native names, no retired spelling appears, and the output reparses under the canonical catalog.Verification
cargo fmt --check, clippy, and workspace tests pass.OWBastion/Bastionatf693704:src/main.opy(zh-CN) andsrc/externalMain.opy(en-US) compile throughopy-cli; the retired spelling appears 0 times andSet Player Allowed Heroes5 times in en-US.Not verified
wright compileonworkshop-rs0.8.0 with the new provider, and the builtin probe re-run.Refs #399