Skip to content

fix(manifest): remove duplicate startHoT entry - #397

Merged
e54-bot merged 3 commits into
mainfrom
fix/396-start-hot
Sep 26, 2026
Merged

e54-bot merged 3 commits into
mainfrom
fix/396-start-hot

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep one startHoT manifest entry with the pinned OverPy 9.7.10 signature: healer, duration, healingPerSecond.
  • Add a pinned-oracle probe covering positional and keyword calls. The oracle confirms all three arguments are required and these are the accepted keyword names.
  • Existing manifest validation already rejects duplicate function IDs.

Verification

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo test --workspace --all-targets --all-features
  • python3 -m unittest discover -s tools/overpy/tests
  • python3 crates/opy-rs/src/manifest/probes/validate.py
  • python3 tools/overpy/probe_builtins.py --binary target/debug/opy-compat --functions startHoT (24/24 match)

Fixes #396

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One actionable verification gap remains.

Comment thread crates/opy-rs/src/manifest/probes/start-hot-signature.opy
@e54-bot
e54-bot enabled auto-merge September 26, 2026 07:38
@e54-bot
e54-bot requested a review from Teakowa September 26, 2026 07:44

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e54-bot
e54-bot merged commit e599fc9 into main Sep 26, 2026
5 checks passed
@e54-bot
e54-bot deleted the fix/396-start-hot branch September 26, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the duplicate startHoT manifest entry

2 participants