Skip to content

Migrate to the workshop-rs 1.0 public API #359

Description

@Teakowa

Goal

Migrate opy-rs to the final supported workshop-rs public API and verify the workshop-rs 1.0 release candidate through OPY-owned workflows.

Context

workshop-rs#252 requires opy-rs to consume and verify the 1.0 candidate before release.

Candidate verification after workshop-rs#268 exposed remaining dependencies on API that is no longer part of the supported public contract:

  • private workshop_rs::wir;
  • the removed SettingDefinition::provenance() API.

These are consumer migration gaps owned by opy-rs; they should not be solved by restoring private or superseded workshop-rs surfaces.

Scope

  • Replace remaining direct uses of private workshop_rs::wir with the supported canonical public Program/Workshop-domain APIs.
  • Replace use of SettingDefinition::provenance() with the current concrete public source/data contract where the behavior is still required.
  • Keep OPY semantics and compatibility behavior unchanged.
  • Verify the final workshop-rs 1.0 candidate through the relevant opy-rs tests, compiler/provider workflows, formatting, and Clippy gates.

Non-goals

  • Restoring private WIR or deprecated provenance APIs in workshop-rs.
  • Reimplementing Workshop semantics inside opy-rs.
  • Changing the Program-to-OPY reconstruction contract tracked separately by Define the scoped Workshop Program to OPY reconstruction contract #254.
  • Expanding OPY language compatibility beyond what is required for this dependency migration.

Acceptance criteria

  • opy-rs no longer depends on private workshop_rs::wir or the removed SettingDefinition::provenance() API.
  • The migration uses supported workshop-rs public contracts without duplicating Workshop semantics.
  • Relevant OPY compiler/provider tests and repository-required quality gates pass against the final workshop-rs 1.0 candidate.
  • The successful verification can satisfy the opy-rs consumer gate in wrightkit/workshop-rs#252.

Ownership

  • opy-rs: owns this consumer migration and OPY workflow verification.
  • workshop-rs: owns the canonical Workshop public API and 1.0 candidate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions