feat(protocol): negotiate artifact formats in lpp/compile - #40
Merged
Merged
Conversation
Add optional acceptedArtifactFormats to lpp/compile in LPP 1.4. The provider returns the first listed format it can produce, refuses when none is supported, and behaves as in 1.3 when the field is absent. Sessions before 1.4 reject the field with -32602. The mock provider gains a compile-only x-demo/puzzle-summary-v1 format, and fixtures 45-49 cover selection, absence, refusal, the version gate, and invalid values. Fixes #39
Teakowa
requested changes
Sep 24, 2026
Teakowa
left a comment
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
One blocking protocol-contract inconsistency remains.
Clarify that providers ignore unknown fields except fields defined for a later version that they implement, which are rejected as specified, and that clients may rely on a version-gated field only in a session that negotiated that version.
Teakowa
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
Summary
acceptedArtifactFormats(ordered format ids) onlpp/compile.format/contentenvelope; no Workshop semantics defined here.x-demo/puzzle-summary-v1; fixtures 45-49 cover selection, absence, refusal, version gate, invalid values.Validation
fmt, clippy -D warnings, cargo test --workspace, fixture validate-only and mock-provider conformance (49/49), git diff --check.