Fix caplog not capturing INFO logs in train model cleanup tests - #1143
Open
mborodii-prog wants to merge 2 commits into
Open
Fix caplog not capturing INFO logs in train model cleanup tests#1143mborodii-prog wants to merge 2 commits into
mborodii-prog wants to merge 2 commits into
Conversation
test_classify_write_logs_new_model_id_integration, test_lookup_write_logs_new_model_id, and test_standardize_write_logs_new_model_id create real models via name: and rely on caplog to find the "New <type> model created" log line to delete them in a finally block. pytest's caplog fixture only captures WARNING+ by default, so the INFO record was never created and the cleanup silently no-op'd, leaking a new model on every run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_classify_write_logs_new_model_id_integration, test_lookup_write_logs_new_model_id, and test_standardize_write_logs_new_model_id create real models via name: and rely on caplog to find the "New model created" log line to delete them in a finally block. pytest's caplog fixture only captures WARNING+ by default, so the INFO record was never created and the cleanup silently no-op'd, leaking a new model on every run.