Repository navigation
Give the Docker workers the database host, port and socket #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Protect the socket directory from unrelated host users.
When the temporary directory is shared
/tmp, mode0777lets another local UID remove or replacemysqld.sock. The sticky bit on/tmpdoes not protect entries inside this child directory. This can break subsequent socket connections from the worker. (man7.org)Place the shared directory beneath a runner-owned
0700host directory. Bind-mount only the child into both containers. This preserves access for their different UIDs without exposing the endpoint to other host users.Based on learnings, “Unrestricted access can expose secrets or allow tampering.”
ast-grep (0.51.1)
[error] 614-614: Do not create a file with too many permissions
Context: chmod( $socket_dir, 0777 )
Note: [CWE-732] Incorrect Permission Assignment for Critical Resource.
(write-file-permissions-php)
Sources: Learnings, Linters/SAST tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this against the code, and the finding is correct. The socket directory is created directly in
sys_get_temp_dir()with mode0777and no sticky bit. On a host shared with other users, any local user can delete or replacemysqld.sock, which breaks that worker's socket connections. The/tmpsticky bit only protects the directory entry itself, not files inside it.The suggested change would work: create a runner-owned
0700parent, keep the0777socket directory inside it, and bind-mount only that child. The DB container (mysql uid) and the worker (runner uid) reach the socket through their own mount points and never go through the host parent, so access is unchanged.The practical risk is low, because GitHub runners and local dev machines are normally single-user. I'm leaving this open for the PR owner to decide whether to include the change here.
Generated by Claude Code