Repository navigation
Import from and export to Rotation Master - #1598
Closed
corporategoth wants to merge 1 commit into
Closed
corporategoth wants to merge 1 commit into
corporategoth wants to merge 1 commit into
Conversation
Rotation Master is the World of Warcraft addon (and rotationmaster.neuromancy.net) that suggests the next action from a priority list. Its rotations are shared as a text export. This adds it to the Import and Export menus. Import converts an export into an APL and lists what became of every step: exact, approximate, lossy or unsupported. On confirmation it replaces the APL and nothing else, so gear, talents, buffs, the encounter and the other settings stay as they were. Export writes the APL, or the priority list the simulator generates for an Auto or Simple rotation, as a Rotation Master export, with a warning that fidelity may be lost and the same per-step report. The converters are pure and live in rotation_master/ with their rule table; the host glue is in importers/ and the dialogs are in components/RotationMaster/.
Author
|
Closing this PR. The maintainers' response made clear they are not interested in community contributions that support smaller addons (Rotation Master has roughly 200k downloads, which was treated as too small to matter). Because of that attitude toward addon developers, Rotation Master is removing its WowSims import/export support entirely and will no longer contribute to or support this project. Thanks to anyone who looked at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Rotation Master to the Import and Export menus. Rotation Master is a World of Warcraft addon (and rotationmaster.neuromancy.net) that suggests the next action from a priority list; its rotations are shared as a text export.
Import converts an export into an APL and lists what became of every step: exact, approximate, lossy or unsupported, each with the reason. Check changes nothing. Replace rotation then replaces the APL and nothing else, so gear, talents, buffs, the encounter and the other settings stay as they were. A second button hides the steps that lost a condition.
Export writes the APL (or the priority list the simulator generates for an Auto or Simple rotation) as a Rotation Master export, with a warning that fidelity may be lost and the same per-step report. Steps that are not exact copies are exported disabled. The rotation is scoped to the spec.
What does not carry over: Rotation Master has no timeline, fight length, cast times or simulator state, so conditions on those are reported and left out. Waiting, pet actions, item sets and Assisted Combat have no counterpart.
The converters are pure TypeScript with no dependencies (
ui/features/import-export/rotation_master/), driven by one rule table. The host glue is inimporters/rotation_master.ts, the dialogs incomponents/RotationMaster/. English and French strings, and the schema, are added together.Gates run locally on this branch (CI's
build-uisteps):npm run test:localesvalid,npm run fmtclean,npm run lint:js0 warnings,npm run lint:cssclean,npm run type-checkclean,npm run test:unit251 files / 1944 tests pass. No Go changes. Tried in a browser against a local build (Fire Mage): the menu entries, Check with its report, Replace rotation (gear untouched, the Rotation tab shows the imported APL) and Export. Not tested: importing an exported string into the addon in the game. The French text wants a native read.