Repository navigation
feat(transport): send WorkOS Android/<version> User-Agent header - #5
Merged
Merged
Conversation
Requests previously went out with OkHttp's default UA (okhttp/4.12.0), making Android SDK traffic unattributable in fct_log_events_sdk. The header mirrors the WorkOS iOS/<version> shape with an end-anchored version so the data platform's regex convention applies unchanged. The version const is stamped by release-please via a new extra-files entry, keeping it in lockstep with build.gradle.kts.
Greptile SummaryThe PR identifies Android SDK traffic by adding a versioned User-Agent header and configures release-please to keep that version synchronized with releases.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The fixed User-Agent is applied to all transport requests, remains overridable through existing request headers, and uses a release-please marker compatible with the repository’s release configuration. Important Files Changed
Reviews (1): Last reviewed commit: "feat(transport): send a WorkOS Android/<..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-Agent(okhttp/4.12.0), leaving Android SDK traffic unattributable in the data platform'sfct_log_events_sdkmodel.Transportnow setsUser-Agent: WorkOS Android/<version>on every request, mirroring theWorkOS iOS/<version>shape with an end-anchored version so the existing regex convention applies unchanged. Per-requestRequestOptionsheaders can still override it.Transport.ktcarries thex-release-please-versionmarker and is registered inrelease-please-config.jsonextra-files, so release-please stamps it in lockstep withbuild.gradle.kts— no manual updates.WorkOS Android/[^\s]+.Note:
fct_log_events_sdk.sqlinworkos/data-platformstill needs a"WorkOS Android"entry in itssdksmap before attribution shows up there.