Repository navigation
fix(session): Reject non-user access tokens in session cookies - #16
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from madison.packer
|
Contributor
Devin Review🟢 Devin Review found nothing to fix · View findings |
[High impact] The PR appears safe to merge. SummarySession-cookie authentication now rejects non-user tokens after signature and time checks, before the optional issuer check.
Reviews (1) · Last reviewed commit: "fix(session): Reject non-user access tok..." · Reviewed by Greptile |
Collaborator
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionCookie.authenticate()andSession.authenticateWithSessionCookie()now accept only user access tokens. Other tokens signed by the same environment key (agent and widget tokens) returnINVALID_JWT. This matches workos-kotlin and the other WorkOS SDKs.JwksVerifier.isValidchecks the token after signature/expverification and before the optionalissuerscheck:User access tokens always include
sidandauth_time, and they omitsub_profileor set it to"user". ThesignedJwttest helper now sets both by default. The new rejection test fails without the change.Link to Devin session: https://app.devin.ai/sessions/7e123fc2545a49c282b043a4abd58f70
Open in Devin Desktop: https://app.devin.ai/desktop/session/7e123fc2545a49c282b043a4abd58f70?variant=devin
Requested by: @m0tzy