Repository navigation
chore: keep breaking changes at a minor bump while pre-1.0 - #10
Merged
Merged
Conversation
This SDK is still 0.x. Without bump-minor-pre-major, the first feat(generated)! commit from the oagen pipeline would make release-please propose 1.0.0 (as happened in workos-ios#29). Match workos-ios#35 and the authkit-* repos so breaking changes bump the minor version instead.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This SDK is still pre-1.0. Release-please treats any breaking change on a 0.x version as a major bump by default, so the first
feat(generated)!:commit from the oagen pipeline would propose 1.0.0. That just happened in workos/workos-ios#29 and was fixed in workos/workos-ios#35.What
Adds
"bump-minor-pre-major": truetorelease-please-config.json. Breaking changes bump minor (0.3.0 → 0.4.0). Features still bump minor and fixes still bump patch, so the existing 0.x cadence is unchanged.Same setting as
authkit-react,authkit-js,workos-ios,workos-python, andworkos-elixir.