Skip to content

chore: keep breaking changes at a minor bump while pre-1.0 - #10

Merged
gjtorikian merged 1 commit into
mainfrom
chore/bump-minor-pre-major
Sep 15, 2026
Merged

gjtorikian merged 1 commit into
mainfrom
chore/bump-minor-pre-major

Conversation

@gjtorikian

Copy link
Copy Markdown
Collaborator

Why

This SDK is still pre-1.0. Release-please treats any breaking change on a 0.x version as a major bump by default, so the first feat(generated)!: commit from the oagen pipeline would propose 1.0.0. That just happened in workos/workos-ios#29 and was fixed in workos/workos-ios#35.

What

Adds "bump-minor-pre-major": true to release-please-config.json. Breaking changes bump minor (0.3.0 → 0.4.0). Features still bump minor and fixes still bump patch, so the existing 0.x cadence is unchanged.

Same setting as authkit-react, authkit-js, workos-ios, workos-python, and workos-elixir.

This SDK is still 0.x. Without bump-minor-pre-major, the first
feat(generated)! commit from the oagen pipeline would make release-please
propose 1.0.0 (as happened in workos-ios#29). Match workos-ios#35 and the
authkit-* repos so breaking changes bump the minor version instead.
@gjtorikian
gjtorikian merged commit 1423ae9 into main Sep 15, 2026
7 checks passed
@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

This PR appears safe to merge. No broken release path was found.

Summary

Release-please now keeps breaking changes on the Android SDK’s 0.x minor-release path. This prevents a breaking change from jumping directly to 1.0.0 while keeping feature and fix bumps unchanged.

Diagram

sequenceDiagram
    participant Dev as Developer
    participant GitHub
    participant RP as release-please
    participant Config as release-please-config.json
    participant Manifest as .release-please-manifest.json
    participant Maven as Maven Central

    Dev->>GitHub: Push commits to main
    GitHub->>RP: Run release-please action 5.0.0
    RP->>Config: Read root package settings
    Config-->>RP: bump-minor-pre-major is true
    RP->>Manifest: Read current version 0.3.0
    alt Breaking change before 1.0
        RP->>GitHub: Open or update release PR for 0.4.0
    else Feature before 1.0
        RP->>GitHub: Open or update minor release PR
    else Fix before 1.0
        RP->>GitHub: Open or update patch release PR
    end
    Dev->>GitHub: Merge release PR
    GitHub->>RP: Run on updated main
    RP->>GitHub: Create tag and GitHub Release
    GitHub->>Maven: Trigger artifact publish
Loading

Reviews (1) · Last reviewed commit: "chore: keep breaking changes at a minor ..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant