Repository navigation
ci: announce published packages on Discord #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RedStar071
wants to merge
3
commits into
main
Choose a base branch
from
claude/hopeful-lovelace-6j2r91
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: announce | ||
|
|
||
| # Re-sends, or previews, the Discord announcement of packages that are already | ||
| # published. The release workflow announces new releases on its own. | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| packages: | ||
| description: "Published packages, as name@version separated by commas (e.g. @wolfstar/plugin-api@3.1.0,@wolfstar/plugin-cache@0.4.0)" | ||
| type: string | ||
| required: true | ||
| dry-run: | ||
| description: Render into the job summary without sending anything | ||
| type: boolean | ||
| default: true | ||
|
|
||
| permissions: {} | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| announce: | ||
| name: 📣 Announce packages | ||
| if: github.repository_owner == 'wolfstar-project' | ||
| permissions: | ||
| contents: read # the changelogs | ||
| pull-requests: read # pull request titles for the bullets | ||
| uses: wolfstar-project/.github/.github/workflows/reusable-announce-packages.yml@main | ||
| with: | ||
| published-packages: ${{ inputs.packages }} | ||
| dry-run: ${{ inputs.dry-run }} | ||
| role-id: ${{ vars.DISCORD_PACKAGES_ROLE_ID }} | ||
| secrets: | ||
| DISCORD_WEBHOOK_URL: ${{ secrets.DISCORD_PACKAGES_WEBHOOK_URL }} | ||
| RELEASE_WEBHOOK_URL: ${{ secrets.RELEASE_WEBHOOK_URL }} | ||
| RELEASE_WEBHOOK_SECRET: ${{ secrets.RELEASE_WEBHOOK_SECRET }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reusable-announce-packages.ymlis not inwolfstar-project/.githubyet (the contents API returns 404, and there is no open PR there). A caller that references a missing reusable workflow stops the wholerelease.ymlrun from starting, which would block the@nextsnapshot and the release publish onmain. The PR is no longer a draft, so please keep the merge gated on the.githubPR landing first.Technical details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the open question: yes,
published-packagestakes both shapes. The action reads a value that starts with[as the JSON arraychangesets/actionemits (entries without a stringnameandversionare dropped), and otherwise asname@versionentries separated by commas or spaces.parsePublishedcovers both in its tests. I also checked everywith:andsecrets:name of the callers against the inputs and secrets the two reusable workflows declare, and none is unknown or missing.The merge gate stays: please do not merge this before
reusable-announce-packages.ymlis onwolfstar-project/.githubmain. I cannot open that PR from this session, so it is for the maintainer to land.Generated by Claude Code