Repository navigation
feat(dashboard): make the shell usable on phones - #83
Merged
Merged
Conversation
Below 768px the sidebar was hidden with nothing in its place, so Audit, Settings, the account and sign-out were unreachable. The sidebar now opens as a drawer from a per-page navbar, following the layout of the Nuxt UI dashboard starter within the existing UnoCSS design system. - AppNavbar replaces three copies of the page header; language and theme move to the sidebar footer with the account - Metrics become one strip that reflows without an orphan cell - New task opens in a native modal dialog from the navbar - Define the missing btn-primary shortcut and replace text-error with text-danger, which left the queue and approve buttons unstyled
Architecture Inside the changed components — 1 viewComponent view — Web application shell Responsive navigation shell, top navbar, and modal dialog components in the web application.
Data flow Tip After a push, tick Redraw to draw the latest commit 🪧 More tips
Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it. |
Shortcuts outside the new-task dialog stand down while it is open, so `g a` no longer navigates away from a draft and `?` no longer opens the sheet behind the modal. The drawer now scrolls everything below the brand, so the account and preferences stay reachable on a short screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a phone the dashboard hid its sidebar and offered nothing in its place, so Audit, Settings, the account and sign-out could not be reached. The header also crammed the language picker, theme toggle, clock and refresh into one row.
The shell now follows the layout of the Nuxt UI dashboard starter, built with the existing UnoCSS tokens:
md, the sidebar opens as a drawer from a menu button. It takes focus when it opens and closes on Escape, a backdrop tap or navigation, and the page behind it isinert.AppNavbarreplaces the three hand-copied page headers (Control Plane, Audit, Settings) and is added to Organizations. It holds the title and page actions only; on phones the actions become 44 px icon buttons.RunnerMetricsbecomes onedlstrip that reflows from two to five columns without an empty cell.dialogfrom a navbar button instead of thedetailsblock in the page body.btn-primaryandtext-errorwere used but never defined, so Queue task and Approve rendered unstyled. This addsbtn-primarytoapps/web/uno.config.tsand usestext-danger.Why
The change stays inside
apps/webandpackages/i18n. It does not add@nuxt/ui, which would bring Tailwind alongside UnoCSS and break the contract inpackages/ui/DESIGN.md. The i18n change removes the unused eyebrow and mode keys, adds the drawer's open and close labels in English and Italian, and regenerates the schema.Verification
aube run check:repoaube run lint:ciaube run typecheckaube testaube run buildSafety and compatibility
observemode as read-only, or explained the policy change above.Agent context
Reviewer notes
The e2e tests still find the theme button and language picker by name; they now live in the sidebar, which is visible at the desktop viewport. The sidebar's "System status: Healthy" indicator is hard-coded and was left as is; it should be wired to a real check or removed in a follow-up.


Confidence Score: 5/5
The PR appears safe to merge; both previous findings are addressed and no new blocking issues were found.Reviews (2) · Last reviewed commit: "fix(dashboard): keep shortcuts and the d..." · Reviewed by Greptile