Repository navigation
fix(dashboard): turn off the Worker's preview URLs - #82
Merged
Merged
Conversation
With preview URLs on, every uploaded version of the Worker gets its own public hostname. The dashboard keeps its workers.dev address but no longer publishes per-version previews.
|
Architecture Data flow No data-flow sequence changed in this PR. Tip The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change 🪧 More tips
Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets
preview_urlstofalseinapps/web/wrangler.jsonc. The Worker keeps itsworkers.devaddress and theapp.code-zero.devcustom domain. It no longer publishes a separate public hostname for each uploaded version.Why
Wrangler turns preview URLs on by default when
workers_devis enabled andpreview_urlsis not set, and it warned about this on the first deploy. A preview URL would serve an unreleased build of the dashboard, with the production bindings, on a hostname nobody reviews.Verification
aube run check:repoaube run lint:ciaube run typecheckaube testaube run buildSafety and compatibility
observemode as read-only, or explained the policy change above.Agent context
Reviewer notes
The change takes effect on the next dashboard deploy. Versions already uploaded keep their preview URLs until then.


Confidence Score: 5/5
The PR appears safe to merge.Reviews (1) · Last reviewed commit: "fix(dashboard): turn off the Worker's pr..." · Reviewed by Greptile