Repository navigation
ci(macos): build the static configuration, the only place Apple's ar rules are exercised - #15
Merged
Merged
Conversation
…rules are exercised Every leg in every job built the DEFAULT configuration, and the default here is BUILD_SHARED_LIBS=ON -- a shared build never runs `ar`. The archive rules in CMakeLists.txt's reproducible-build block are set for `GNU|Clang` (AppleClang matches) and spell `ar qcD` / `qD`, while CMAKE_AR on macOS is cctools `ar`, whose getopt accepts only abcdilLmopqrSsTtuVvx6: `D` reached usage() and exited 1, so every static build on macOS failed at the archive step with nothing in this repository positioned to see it. vcpkg is what found it (its macOS triplets set VCPKG_LIBRARY_LINKAGE static, and vcpkg_cmake_configure passes -DBUILD_SHARED_LIBS=OFF); PR #14 moved the two rules into the existing `if (NOT APPLE)`, merged as 974c504 on 2026-11-21. This leg is what keeps them there. BUILD-ONLY, for the reason the floor leg above already carries: static + the full CTest suite has never run on macOS, and a first run that mixed "the archive rule broke again" with "static tests were never wired on Apple" would answer neither question. Turning the tests on is its own change, after this leg has been green once. Evidence run for this commit: `python -B tools/check_parsable.py --require` -> exit 0 (ci.yml parses with yaml.safe_load, 12 files checked). What could NOT be run: the leg itself -- there is no macOS toolchain on the machine this was written on, so its first CI run is its first evidence, and it is not coverage until that run says so. What would make it red: reverting dd36b92, which is how the failure reads (`ar: illegal option -- D`, from cctools usage()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix this leg guards is #14 (
974c504), already merged: the reproducible-build block spelledar qcD/qDfor everyGNU|Clangbuild, AppleClang included, whileCMAKE_ARon macOS is cctoolsar, whose option parser accepts onlyabcdilLmopqrSsTtuVvx6-- soDreachedusage()and exited 1, and every static build on macOS failed at the archive step. Every leg in this workflow built the DEFAULT configuration, which is shared, and a shared build never runsar; nothing here was positioned to see it. vcpkg was (its macOS triplets setVCPKG_LIBRARY_LINKAGE static).The new leg sits at the end of the
macosjob and is BUILD-ONLY, for the reason the floor leg above already carries: static plus the full CTest suite has never run on macOS, and a first run that mixed "the archive rule broke again" with "static tests were never wired on Apple" would answer neither question. Turning the tests on belongs in its own change, once this leg has been green once.Verified before opening:
python -B tools/check_parsable.py --require-> exit 0 (ci.yml parses withyaml.safe_load; 12 files checked). NOT verified, and not verifiable on the machine this was written on: the leg itself -- there is no macOS toolchain there, so this PR's own run is its first evidence, and it is not coverage until that run says so. What would make it red: revertingdd36b92, which is how the failure reads (ar: illegal option -- D, from cctoolsusage()).