Fix initialization of string in otp_keystore tag#772
Merged
mattia-moffa merged 1 commit intowolfSSL:masterfrom May 6, 2026
Merged
Fix initialization of string in otp_keystore tag#772mattia-moffa merged 1 commit intowolfSSL:masterfrom
mattia-moffa merged 1 commit intowolfSSL:masterfrom
Conversation
Emerged in newer gcc15, due to -Wunterminated-string-initialization added to -Wall
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a GCC 15 -Wunterminated-string-initialization warning/error by changing the OTP keystore header magic initialization from a string literal to an explicit 8-byte character initializer, matching how the value is used (byte-wise memcmp/memcpy) in the OTP keystore implementation and tools.
Changes:
- Replace
static const char KEYSTORE_HDR_MAGIC[8] = "WOLFBOOT";with an explicit 8-byte initializer list to avoid unterminated-string initialization warnings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattia-moffa
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emerged in newer gcc15, due to -Wunterminated-string-initialization added to -Wall
This one-line fixes the initialization of the string and removes the build warning/error from the OTP DICE test.