Repository navigation
Fix handles locking, key wiping, and curve checks - #70
Open
aidangarske wants to merge 13 commits into
Open
aidangarske wants to merge 13 commits into
aidangarske wants to merge 13 commits into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #70
Scan targets checked: go-wolfssl-src, go-wolfssl-bugs
Coverage: 4 of 10 in-scope changed file(s) opened by the reviewer; not opened: handles/aes_handles_test.go, handles/ecc_handles_test.go, handles/rsa_handles_test.go, sha256/sha256.go, sha256/sha256_test.go, wolfx509/certgen_lock_test.go
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
aidangarske
force-pushed
the
fenrir-fixes-handles
branch
from
October 22, 2026 15:55
aab1a5e to
0f36df0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-7861- deab681 - ParseECPrivateKeyDER now rejects curves other than P-256, derives the public point for private only DER, and ECC key handles report P-256.F-9630- f8f0092 - EccKey operations and Free now take a per-key lock, and wolfx509 certificate building locks its keys, which fixes data races between use and Free.F-10946- 6c3677e - RsaKey verify operations and Free now take a per-key lock.F-12016- cfa3983 - The AES-GCM wrapper now registers Wc_AesFree only after Wc_AesInit succeeds.F-6116- 263233a - ParseECPrivateKeyPEM now wipes the decoded private key DER.F-9645- 8088174 - The sha256 digest Write now panics on an update failure instead of returning a nonstandard error.F-10933- 70ed18a - SignDigest now returns an error for an ECC key with no RNG, and the docs say public only keys are verify only.F-10954- 83d4ea4 - AES-GCM decrypt now wipes its output when authentication fails.F-12824- a1afa3a - The SignDigest documentation now states the correct digest length.F-12844- 599e6da - PEM marshaling of private keys now wipes the temporary private key DER.F-12031- 3267240 - The RsaVerifyPSS documentation now states the correct salt length.F-3022- 95cf9d4 - AesGcmAEAD now has a Zero method that wipes its key.CI- aab1a5e - The build workflow now runs go test ./sha256 in the full config.