Use pkg-config to find system leveldb#35
Open
njwhite wants to merge 1 commit into
Open
Conversation
|
I've been down this road already :) https://github.com/vjoel/ruby-leveldb-native Would you like to join that repo? Btw, @wmorgan no longer maintains this repo and gave his blessing to ruby-leveldb-native. |
|
Another approach, instead of pkg-config (not sure how widely installed that is outside of linux), would be to use rake-compiler, as in https://github.com/minad/lmdb. This repo is sort of the best of both worlds: it has a bundled version of lmdb, but tries to find installed libs first. (And you can override that too.) |
|
I've been meaning to use rake-compiler in https://github.com/vjoel/ruby-leveldb-native, but I'm just more interested in working on lmdb now. |
Author
|
@vjoel I will, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't embed our own copy of LevelDB - build against the system on (the one pkg-config knows about) instead.