Merge pull request #428 from wmde/newClaim

Drop deprecated Entity::newClaim

Author: JeroenDeDauw

RELEASE-NOTES.md

@@ -12,6 +12,7 @@
 	* Removed `ClaimList`
 	* Removed `ClaimListAccess`
 	* Removed `hasClaims` from all entity classes
+	* Removed `newClaim` from all entity classes
 * Removed `Claims::getBestClaims` (you can use `StatementList::getBestStatements` instead)
 * Removed `Claims::getByRank` and `Claims::getByRanks` (you can use `StatementList::getWithRank` instead)
 * Removed `Claims::getMainSnaks` (you can use `StatementList::getMainSnaks` instead)

src/Entity/Entity.php

@@ -371,18 +371,6 @@ public function getClaims() {
 		return array();
 	}
 
-	/**
-	 * @since 0.3
-	 * @deprecated since 1.0, use new Statement() instead.
-	 *
-	 * @param Snak $mainSnak
-	 *
-	 * @return Statement
-	 */
-	public function newClaim( Snak $mainSnak ) {
-		return new Statement( $mainSnak );
-	}
-
 	/**
 	 * Returns an EntityDiff between $this and the provided Entity.
 	 *

src/Entity/Item.php

@@ -199,17 +199,6 @@ public function getType() {
 		return self::ENTITY_TYPE;
 	}
 
-	/**
-	 * @deprecated since 1.0, use new Statement() instead.
-	 *
-	 * @param Snak $mainSnak
-	 *
-	 * @return Statement
-	 */
-	public function newClaim( Snak $mainSnak ) {
-		return new Statement( $mainSnak );
-	}
-
 	/**
 	 * Returns if the Item has no content.
 	 * Having an id set does not count as having content.

src/Entity/Property.php

@@ -222,17 +222,6 @@ public function setClaims( Claims $claims ) {
 		$this->statements = new StatementList( iterator_to_array( $claims ) );
 	}
 
-	/**
-	 * @deprecated since 1.0, use new Statement() instead.
-	 *
-	 * @param Snak $mainSnak
-	 *
-	 * @return Statement
-	 */
-	public function newClaim( Snak $mainSnak ) {
-		return new Statement( $mainSnak );
-	}
-
 	/**
 	 * @deprecated since 1.0, use getStatements()->addStatement() instead.
 	 *

tests/unit/Entity/ItemTest.php

@@ -494,17 +494,6 @@ public function testHasLinkToSiteForTrue() {
 		$this->assertTrue( $item->getSiteLinkList()->hasLinkWithSiteId( 'foo bar' ) );
 	}
 
-	public function testNewClaimReturnsStatementWithProvidedMainSnak() {
-		/** @var Snak $snak */
-		$snak = $this->getMock( 'Wikibase\DataModel\Snak\Snak' );
-
-		$item = new Item();
-		$statement = $item->newClaim( $snak );
-
-		$this->assertInstanceOf( 'Wikibase\DataModel\Statement\Statement', $statement );
-		$this->assertEquals( $snak, $statement->getMainSnak() );
-	}
-
 	public function testSetClaims() {
 		$item = new Item();
 

tests/unit/Entity/PropertyTest.php

@@ -232,16 +232,6 @@ public function testPropertyWithStatementsIsNotEmpty() {
 		$this->assertFalse( $property->isEmpty() );
 	}
 
-	public function testNewClaimReturnsStatementWithProvidedMainSnak() {
-		$snak = $this->getMock( 'Wikibase\DataModel\Snak\Snak' );
-
-		$property = Property::newFromType( 'string' );
-		$statement = $property->newClaim( $snak );
-
-		$this->assertInstanceOf( 'Wikibase\DataModel\Statement\Statement', $statement );
-		$this->assertEquals( $snak, $statement->getMainSnak() );
-	}
-
 	public function testSetClaims() {
 		$property = Property::newFromType( 'string' );