Merge pull request #431 from wmde/deprecatedClaim

Replace Claim alias with Statement

Author: JeroenDeDauw

src/Entity/Entity.php

@@ -4,11 +4,11 @@
 
 use InvalidArgumentException;
 use RuntimeException;
-use Wikibase\DataModel\Claim\Claim;
 use Wikibase\DataModel\Entity\Diff\EntityDiff;
 use Wikibase\DataModel\Entity\Diff\EntityDiffer;
 use Wikibase\DataModel\Entity\Diff\EntityPatcher;
 use Wikibase\DataModel\Snak\Snak;
+use Wikibase\DataModel\Statement\Statement;
 use Wikibase\DataModel\Term\AliasGroup;
 use Wikibase\DataModel\Term\AliasGroupList;
 use Wikibase\DataModel\Term\Fingerprint;
@@ -352,20 +352,20 @@ public function copy() {
 	 * @since 0.3
 	 * @deprecated since 1.0, use getStatements()->addStatement() instead.
 	 *
-	 * @param Claim $claim
+	 * @param Statement $statement
 	 *
 	 * @throws InvalidArgumentException
 	 * @throws RuntimeException
 	 */
-	public function addClaim( Claim $claim ) {
-		throw new RuntimeException( 'Claims on entities are not supported any more.' );
+	public function addClaim( Statement $statement ) {
+		throw new RuntimeException( 'Statements on entities are not supported any more.' );
 	}
 
 	/**
 	 * @since 0.3
 	 * @deprecated since 1.0, use getStatements()->toArray() instead.
 	 *
-	 * @return Claim[]
+	 * @return Statement[]
 	 */
 	public function getClaims() {
 		return array();
@@ -377,10 +377,10 @@ public function getClaims() {
 	 *
 	 * @param Snak $mainSnak
 	 *
-	 * @return Claim
+	 * @return Statement
 	 */
 	public function newClaim( Snak $mainSnak ) {
-		return new Claim( $mainSnak );
+		return new Statement( $mainSnak );
 	}
 
 	/**

src/Entity/Item.php

@@ -4,7 +4,6 @@
 
 use InvalidArgumentException;
 use OutOfBoundsException;
-use Wikibase\DataModel\Claim\Claim;
 use Wikibase\DataModel\Claim\Claims;
 use Wikibase\DataModel\SiteLink;
 use Wikibase\DataModel\SiteLinkList;
@@ -240,14 +239,12 @@ public function clear() {
 	/**
 	 * @deprecated since 1.0, use getStatements()->addStatement() instead.
 	 *
-	 * @param Claim $statement This needs to be a Statement as of 1.0
+	 * @param Statement $statement
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function addClaim( Claim $statement ) {
-		if ( !( $statement instanceof Statement ) ) {
-			throw new InvalidArgumentException( '$statement must be an instance of Statement' );
-		} elseif ( $statement->getGuid() === null ) {
+	public function addClaim( Statement $statement ) {
+		if ( $statement->getGuid() === null ) {
 			throw new InvalidArgumentException( 'Can\'t add a Claim without a GUID.' );
 		}
 

src/Entity/Property.php

@@ -3,7 +3,6 @@
 namespace Wikibase\DataModel\Entity;
 
 use InvalidArgumentException;
-use Wikibase\DataModel\Claim\Claim;
 use Wikibase\DataModel\Claim\Claims;
 use Wikibase\DataModel\Snak\Snak;
 use Wikibase\DataModel\Statement\Statement;
@@ -237,14 +236,12 @@ public function newClaim( Snak $mainSnak ) {
 	/**
 	 * @deprecated since 1.0, use getStatements()->addStatement() instead.
 	 *
-	 * @param Claim $statement This needs to be a Statement as of 1.0
+	 * @param Statement $statement
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function addClaim( Claim $statement ) {
-		if ( !( $statement instanceof Statement ) ) {
-			throw new InvalidArgumentException( '$statement must be an instance of Statement' );
-		} elseif ( $statement->getGuid() === null ) {
+	public function addClaim( Statement $statement ) {
+		if ( $statement->getGuid() === null ) {
 			throw new InvalidArgumentException( 'Can\'t add a Claim without a GUID.' );
 		}