Removed no longer used newFromRepositoryAndNumber from ItemId/PropertyId

Bug: T291823
Change-Id: Ie22e6b41d1cda46b531464b9d73fb2441322c522

Author: manicki

src/Entity/ItemId.php

@@ -113,26 +113,4 @@ public static function newFromNumber( $numericId ) {
 		return new self( 'Q' . $numericId );
 	}
 
-	/**
-	 * CAUTION: Use the full string serialization whenever you can and avoid using numeric IDs.
-	 *
-	 * @since 7.0
-	 *
-	 * @param string $repositoryName
-	 * @param int|float|string $numericId
-	 *
-	 * @return self
-	 * @throws InvalidArgumentException
-	 */
-	public static function newFromRepositoryAndNumber( $repositoryName, $numericId ) {
-		if ( !is_numeric( $numericId ) ) {
-			throw new InvalidArgumentException( '$numericId must be numeric' );
-		}
-		if ( $repositoryName !== '' ) {
-			throw new InvalidArgumentException( 'repo name no longer supported (T291823)' );
-		}
-
-		return new self( self::joinSerialization( [ $repositoryName, '', 'Q' . $numericId ] ) );
-	}
-
 }

src/Entity/NumericPropertyId.php

@@ -107,23 +107,4 @@ public static function newFromNumber( $numericId ) {
 		return new self( 'P' . $numericId );
 	}
 
-	/**
-	 * CAUTION: Use the full string serialization whenever you can and avoid using numeric IDs.
-	 *
-	 * @param string $repositoryName
-	 * @param int|float|string $numericId
-	 *
-	 * @return self
-	 * @throws InvalidArgumentException
-	 */
-	public static function newFromRepositoryAndNumber( $repositoryName, $numericId ) {
-		if ( !is_numeric( $numericId ) ) {
-			throw new InvalidArgumentException( '$numericId must be numeric' );
-		}
-		if ( $repositoryName !== '' ) {
-			throw new InvalidArgumentException( 'repo name no longer supported (T291823)' );
-		}
-
-		return new self( self::joinSerialization( [ $repositoryName, '', 'P' . $numericId ] ) );
-	}
 }

tests/unit/Entity/ItemIdTest.php

@@ -150,14 +150,4 @@ public static function invalidNumericIdProvider() {
 		];
 	}
 
-	public function testNewFromRepositoryAndNumber() {
-		$id = ItemId::newFromRepositoryAndNumber( '', 1 );
-		$this->assertSame( 'Q1', $id->getSerialization() );
-	}
-
-	public function testNewFromRepositoryAndNumberWithInvalidNumericId() {
-		$this->expectException( InvalidArgumentException::class );
-		ItemId::newFromRepositoryAndNumber( '', 'Q1' );
-	}
-
 }

tests/unit/Entity/NumericPropertyIdTest.php

@@ -149,14 +149,4 @@ public static function invalidNumericIdProvider() {
 		];
 	}
 
-	public function testNewFromRepositoryAndNumber() {
-		$id = NumericPropertyId::newFromRepositoryAndNumber( '', 1 );
-		$this->assertSame( 'P1', $id->getSerialization() );
-	}
-
-	public function testNewFromRepositoryAndNumberWithInvalidNumericId() {
-		$this->expectException( InvalidArgumentException::class );
-		NumericPropertyId::newFromRepositoryAndNumber( '', 'P1' );
-	}
-
 }